search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

HOSTEDCP-1791: dont render cloud-credentials secret #4406

Closed Patryk-Stefanski closed 1 month ago

Patryk-Stefanski commented 1 month ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #

Checklist

openshift-ci-robot commented 1 month ago

@Patryk-Stefanski: This pull request references HOSTEDCP-1791 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4406): > > >**What this PR does / why we need it**: > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Patryk-Stefanski commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@Patryk-Stefanski: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/hypershift/pull/4406#issuecomment-2245654797): >/retest required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bryan-cox commented 1 month ago

/test e2e-aks

bryan-cox commented 1 month ago

/test e2e-azure

fxierh commented 1 month ago

/lgtm

enxebre commented 1 month ago

Please default to not rendering sensitive info once the relevant jobs have been updated. fwiw this won't be an issue when moving to msi /approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [enxebre] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jparrill commented 1 month ago

/lgtm

fxierh commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 933f5f2810a6f6ee3704716e9d0a77107edf7d3e and 2 for PR HEAD 13c4722ce8f1e14fdf6d99772d848de056fdf5ed in total

Patryk-Stefanski commented 1 month ago

/test all

Patryk-Stefanski commented 1 month ago

/test all

bryan-cox commented 1 month ago

/retest

for konflux

Patryk-Stefanski commented 1 month ago

/retest-required

Patryk-Stefanski commented 1 month ago

/retest

bryan-cox commented 1 month ago

/lgtm

stevekuznetsov commented 1 month ago

Please default to not rendering sensitive info ...

@enxebre wouldn't this break every consumer of --render that uses the output as a self-contained mechanism to install HostedClusters on a management plane?