openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OSASINFRA-3312: Implements OpenStack Node pools #4409

Closed EmilienM closed 1 month ago

EmilienM commented 1 month ago

What this PR does / why we need it:

This PR adds OpenStack node pools support. It create a basic node pool with a flavor and image name (for now). CLI options are updated.

openshift-ci-robot commented 1 month ago

@EmilienM: This pull request references OSASINFRA-3312 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4409): >**What this PR does / why we need it**: > >This PR adds OpenStack node pools support. >It create a basic node pool with a flavor and image name (for now). >CLI options are updated. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit 4c7d6da35a9180dbeb8da73e3cd4c0685f5414fc
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66a0032b7bfc2c0008735f1b
Deploy Preview https://deploy-preview-4409--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 1 month ago

/cc MaysaMacedo bryan-cox

MaysaMacedo commented 1 month ago

/lgtm

MaysaMacedo commented 1 month ago

/test e2e-openstack

EmilienM commented 1 month ago

Note about e2e-openstack, it's going to fail for sure as the job is still not fully working yet but we're actively working on it.

EmilienM commented 1 month ago

/test e2e-aks e2e-azure e2e-ibmcloud-iks e2e-ibmcloud-roks

openshift-ci[bot] commented 1 month ago

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 21759c4244d463662bce675046b9d72488ca3f21 link false /test e2e-ibmcloud-iks
ci/prow/e2e-openstack 21759c4244d463662bce675046b9d72488ca3f21 link false /test e2e-openstack
ci/prow/e2e-ibmcloud-roks 21759c4244d463662bce675046b9d72488ca3f21 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
EmilienM commented 1 month ago

The openstack job failed because the job isn't ready yet and the IBM cloud jobs fail for a reason not related to this PR.

bryan-cox commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407241715.p0.gb1aa633.assembly.stream.el9. All builds following this will include this PR.