search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OSASINFRA-3319: implements required OpenStack credentials #4410

Closed EmilienM closed 1 month ago

EmilienM commented 1 month ago

What this PR does / why we need it:

Refactor/clean and add missing credentials for the OpenStack platform.

openshift-ci-robot commented 1 month ago

@EmilienM: This pull request references OSASINFRA-3319 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4410): >**What this PR does / why we need it**: > >Refactor/clean and add missing credentials for the OpenStack platform. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

EmilienM commented 1 month ago

/cc MaysaMacedo

EmilienM commented 1 month ago

Draft for now because I want to see what's missing before asking for reviews (tests, refactor, etc).

EmilienM commented 1 month ago

@bryan-cox I think this is ready for review. This gave me a working cluster. Let's prove it with:

/test e2e-openstack

Note: the job will fail because Ingress is not working (we'll work on that in 4.18, as it's big for us).

Please let me know if there are things that were not needed or not correct, I'll be happy to change.

EmilienM commented 1 month ago

/retest-required /test e2e-aws /test e2e-aks /test e2e-azure

openshift-ci[bot] commented 1 month ago

@EmilienM: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/hypershift/pull/4410#issuecomment-2248390658): >/test hypershift-operator-main-on-pull-request Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
EmilienM commented 1 month ago

/test e2e-aws

EmilienM commented 1 month ago

/cc bryan-cox

EmilienM commented 1 month ago

/test e2e-aws

EmilienM commented 1 month ago

CI is good, the openstack job isn't ready yet.

MaysaMacedo commented 1 month ago

/lgtm

EmilienM commented 1 month ago

/test e2e-azure

EmilienM commented 1 month ago

/test e2e-azure

openshift-ci[bot] commented 1 month ago

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack c9156c062a38629928ae90f058c2618ba3f37910 link false /test e2e-openstack
ci/prow/e2e-azure bbd3538361f31c72ac1059e2930f1563d0ad2d45 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
EmilienM commented 1 month ago

Azure CI seems unstable today: https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-hypershift-main-e2e-azure But I don't think this is related to this PR.

bryan-cox commented 1 month ago

/approve

Azure e2e is due to a CI issue with https://github.com/openshift/hypershift/pull/4408

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment