search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

HOSTEDCP-1773: Featuregate autoprovision #4411

Open enxebre opened 1 month ago

enxebre commented 1 month ago

What this PR does / why we need it:

In future the implementation and consumer facing APIs of Autoprovision might / might not differ completely. We might /might not choose to integrate karpenter with Cluster API or even use different.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #

Checklist

enxebre commented 1 month ago

/hold to add unit tests

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [enxebre] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit ab088e66c269f157f4f7cf2fa29c1e6dcbc71ecf
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66a0e2d0ee9ebe0008a4bee2
Deploy Preview https://deploy-preview-4411--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

enxebre commented 1 month ago

/test netlify/hypershift-docs/deploy-preview

openshift-ci[bot] commented 1 month ago

@enxebre: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/hypershift/pull/4411#issuecomment-2247719008): >/test netlify/hypershift-docs/deploy-preview > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@enxebre: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks bc85aef1f16b5d759799b96a2751a70372f8d545 link false /test e2e-aks
ci/prow/e2e-aws bc85aef1f16b5d759799b96a2751a70372f8d545 link true /test e2e-aws
ci/prow/images bc85aef1f16b5d759799b96a2751a70372f8d545 link true /test images
ci/prow/e2e-azure bc85aef1f16b5d759799b96a2751a70372f8d545 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@enxebre: This pull request references HOSTEDCP-1773 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4411): > > >**What this PR does / why we need it**: > >- This PR introduces support for Feature gates using Autoprovisioning as the driving use case. >- Featuregates are enabled via "k8s.io/component-base/featuregate" and using Cluster API featuregates implementation as the main example. >- Autoprovisioning is implemented via karpenter aws native provider. When Autoprovisioning feature gate is enabled: > - We create a shim NodePool to generate the userdata. > - We deploy Karpenter aws provider management side watching the guest cluster. > - We install the Karpenter CRDs in the guest cluster. > - We automatically approve all CSRs. > - We watch Karpeneter ec2Classes and inject the right userdata and ami. > >In future the implementation and consumer facing APIs of Autoprovision might / might not differ completely. We might /might not choose to integrate karpenter with Cluster API or even use different. > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
enxebre commented 1 month ago

/retest

enxebre commented 1 month ago

/retest cancel

openshift-ci[bot] commented 1 month ago

@enxebre: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/hypershift/pull/4411#issuecomment-2252423810): >/retest cancel > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 2 weeks ago

/hold

After some discussion today, we would like to discuss the impact of this change and the long term plan here before we merge. We have some concerns about introducing provider specific implementations, how this will be supported and the implications of having a feature-gated feature where we know the future implementation likely won't behave in the same manor.

Would like to have a conversation with @enxebre @elmiko @sub-mod @newtonheath @celebdor