Open enxebre opened 1 month ago
/hold to add unit tests
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: enxebre
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | ab088e66c269f157f4f7cf2fa29c1e6dcbc71ecf |
Latest deploy log | https://app.netlify.com/sites/hypershift-docs/deploys/66a0e2d0ee9ebe0008a4bee2 |
Deploy Preview | https://deploy-preview-4411--hypershift-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/test netlify/hypershift-docs/deploy-preview
@enxebre: The specified target(s) for /test
were not found.
The following commands are available to trigger required jobs:
/test e2e-aws
/test e2e-kubevirt-aws-ovn-reduced
/test images
/test unit
/test verify
The following commands are available to trigger optional jobs:
/test e2e-aks
/test e2e-aws-metrics
/test e2e-azure
/test e2e-azure-ovn-conformance
/test e2e-conformance
/test e2e-ibmcloud-iks
/test e2e-ibmcloud-roks
/test e2e-kubevirt-aws-ovn
/test e2e-kubevirt-azure-ovn
/test e2e-kubevirt-metal-conformance
/test e2e-openstack
/test okd-scos-images
Use /test all
to run the following jobs that were automatically triggered:
pull-ci-openshift-hypershift-main-e2e-aks
pull-ci-openshift-hypershift-main-e2e-aws
pull-ci-openshift-hypershift-main-e2e-azure
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
pull-ci-openshift-hypershift-main-images
pull-ci-openshift-hypershift-main-unit
pull-ci-openshift-hypershift-main-verify
@enxebre: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-aks | bc85aef1f16b5d759799b96a2751a70372f8d545 | link | false | /test e2e-aks |
ci/prow/e2e-aws | bc85aef1f16b5d759799b96a2751a70372f8d545 | link | true | /test e2e-aws |
ci/prow/images | bc85aef1f16b5d759799b96a2751a70372f8d545 | link | true | /test images |
ci/prow/e2e-azure | bc85aef1f16b5d759799b96a2751a70372f8d545 | link | false | /test e2e-azure |
Full PR test history. Your PR dashboard.
@enxebre: This pull request references HOSTEDCP-1773 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.
PR needs rebase.
/retest
/retest cancel
@enxebre: The /retest
command does not accept any targets.
The following commands are available to trigger required jobs:
/test e2e-aws
/test e2e-kubevirt-aws-ovn-reduced
/test images
/test unit
/test verify
The following commands are available to trigger optional jobs:
/test e2e-aks
/test e2e-aws-metrics
/test e2e-azure
/test e2e-azure-ovn-conformance
/test e2e-conformance
/test e2e-ibmcloud-iks
/test e2e-ibmcloud-roks
/test e2e-kubevirt-aws-ovn
/test e2e-kubevirt-azure-ovn
/test e2e-kubevirt-metal-conformance
/test e2e-openstack
/test okd-scos-images
Use /test all
to run the following jobs that were automatically triggered:
pull-ci-openshift-hypershift-main-e2e-aks
pull-ci-openshift-hypershift-main-e2e-aws
pull-ci-openshift-hypershift-main-e2e-azure
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
pull-ci-openshift-hypershift-main-images
pull-ci-openshift-hypershift-main-unit
pull-ci-openshift-hypershift-main-verify
/hold
After some discussion today, we would like to discuss the impact of this change and the long term plan here before we merge. We have some concerns about introducing provider specific implementations, how this will be supported and the implications of having a feature-gated feature where we know the future implementation likely won't behave in the same manor.
Would like to have a conversation with @enxebre @elmiko @sub-mod @newtonheath @celebdor
What this PR does / why we need it:
In future the implementation and consumer facing APIs of Autoprovision might / might not differ completely. We might /might not choose to integrate karpenter with Cluster API or even use different.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story: Fixes #Checklist