openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OCPBUGS-34820: Keep in sync the HC and HCP ICS field #4412

Closed jparrill closed 1 month ago

jparrill commented 1 month ago

The issue happens because the ImageContentSource field from the HostedCluster object in not in sync with the HostedControlPlane ImageContentSource field.

Which issue(s) this PR fixes: Fixes #OCPBUGS-34820

openshift-ci-robot commented 1 month ago

@jparrill: This pull request references Jira Issue OCPBUGS-34820, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4412): >The issue happens because the ImageContentSource field from the HostedCluster object in not in sync with the HostedControlPlane ImageContentSource field. > >**Which issue(s) this PR fixes**: >Fixes #[OCPBUGS-34820](https://issues.redhat.com/browse/OCPBUGS-34820) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit 024ec229f3de87b29384ff2047047d697e8eb078
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66a1014557750600085f9872
Deploy Preview https://deploy-preview-4412--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

csrwng commented 1 month ago

/lgtm

jparrill commented 1 month ago

/retest

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 0bb63014de6b6f8f38deba0c4b5079a71b61f785 and 2 for PR HEAD 40d72e28369c460402f64ff5b42d4f5d351c91fc in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD c2c070a31a17138716f6c53a6a5aa12b405f8e2d and 1 for PR HEAD 40d72e28369c460402f64ff5b42d4f5d351c91fc in total

jparrill commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@jparrill: Jira Issue OCPBUGS-34820: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34820 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4412): >The issue happens because the ImageContentSource field from the HostedCluster object in not in sync with the HostedControlPlane ImageContentSource field. > >**Which issue(s) this PR fixes**: >Fixes #[OCPBUGS-34820](https://issues.redhat.com/browse/OCPBUGS-34820) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407250215.p0.g17953e8.assembly.stream.el9. All builds following this will include this PR.