openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
423 stars 313 forks source link

NO-JIRA: [release-4.15] test/e2e: remove api budget checks #4413

Closed davidvossel closed 2 months ago

davidvossel commented 2 months ago

presub e2e's a failing on this again and with no way to quickly diagnose the situation, we should not block PRs on this.

This isn't a great check as the number of mutating calls is somewhat outside our control with delays in cloud resource create/delete contirbuting to long test durations and more mutating calls.

We need a fundamentally better solution here based on KAS audit log analysis.

Manual backport of https://github.com/openshift/hypershift/pull/4368

openshift-ci-robot commented 2 months ago

@davidvossel: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4413): >presub e2e's a failing on this again and with no way to quickly diagnose the situation, we should not block PRs on this. > >This isn't a great check as the number of mutating calls is somewhat outside our control with delays in cloud resource create/delete contirbuting to long test durations and more mutating calls. > >We need a fundamentally better solution here based on KAS audit log analysis. > >Manual backport of https://github.com/openshift/hypershift/pull/4368 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jparrill commented 2 months ago

/area testing /approve /lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.15/OWNERS)~~ [davidvossel,jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@davidvossel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks 0d0e3fb7292322773417a3bc04f2396534242531 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 0d0e3fb7292322773417a3bc04f2396534242531 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
davidvossel commented 2 months ago

/override "Red Hat Konflux / hypershift-release-mce-25-on-pull-request"

openshift-ci[bot] commented 2 months ago

@davidvossel: Overrode contexts on behalf of davidvossel: Red Hat Konflux / hypershift-release-mce-25-on-pull-request

In response to [this](https://github.com/openshift/hypershift/pull/4413#issuecomment-2250605649): >/override "Red Hat Konflux / hypershift-release-mce-25-on-pull-request" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.15.0-202407251607.p0.gf0b2b6e.assembly.stream.el9. All builds following this will include this PR.

sjenning commented 2 months ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 2 months ago

@sjenning: #4413 failed to apply on top of branch "release-4.14":

Applying: test/e2e: remove api budget checks
Using index info to reconstruct a base tree...
M   test/e2e/e2e_test.go
M   test/e2e/util/hypershift_framework.go
M   test/e2e/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/util/util.go
CONFLICT (content): Merge conflict in test/e2e/util/util.go
Auto-merging test/e2e/util/hypershift_framework.go
CONFLICT (content): Merge conflict in test/e2e/util/hypershift_framework.go
Auto-merging test/e2e/e2e_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test/e2e: remove api budget checks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/hypershift/pull/4413#issuecomment-2256039114): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.