Closed rokej closed 1 month ago
@rokej: This pull request references ACM-12352 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "MCE 2.4.1" instead.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: rokej Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/area dependency
Hey @rokej you need to execute make update
locally to add the new files added by the code generators and then add them to the PR. This is why verify test is failing, it detects that there are something not committed to the PR after the make verify execution
.
PR needs rebase.
@rokej: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/verify | c6c9fd3c2f50552f12c99a85f2076206c37a4894 | link | true | /test verify |
ci/prow/e2e-azure | c6c9fd3c2f50552f12c99a85f2076206c37a4894 | link | false | /test e2e-azure |
ci/prow/e2e-aws-4-17 | c6c9fd3c2f50552f12c99a85f2076206c37a4894 | link | true | /test e2e-aws-4-17 |
ci/prow/security | c6c9fd3c2f50552f12c99a85f2076206c37a4894 | link | true | /test security |
Full PR test history. Your PR dashboard.
What this PR does / why we need it:
This PR is to upgrade the go-retryablehttp to v0.7.7 which fixes CVE-2024-6104 go-retryablehttp: url might write sensitive information to log file.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story: https://issues.redhat.com/browse/ACM-12352Checklist