OCPBUGS-38755: Remove go workspaces from source control

csrwng commented 3 weeks ago

What this PR does / why we need it:

Removes the go.work and go.work.sum files from the repository.
Updates the Makefile to not use go workspaces.
Updates the vendored staticcheck so it won't fail on new style range statements.
Makes minor fixes flagged by staticcheck
Adds instructions for setting up a Go workspace in HACKING doc

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #OCPBUGS-38755

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

openshift-ci-robot commented 3 weeks ago

@csrwng: This pull request references Jira Issue OCPBUGS-38755, which is invalid:

expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4582): >**What this PR does / why we need it**: >Removes go workspaces from code checked in to source control, but allows enabling it locally via >`make enable-workspaces` > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes #[OCPBUGS-38755](https://issues.redhat.com/browse/OCPBUGS-38755) > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [csrwng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

csrwng commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@csrwng: This pull request references Jira Issue OCPBUGS-38755, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to [this](https://github.com/openshift/hypershift/pull/4582#issuecomment-2299836798): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

bryan-cox commented 3 weeks ago

/retest

bryan-cox commented 3 weeks ago

/retest-required

bryan-cox commented 3 weeks ago

/test e2e-aws

openshift-ci-robot commented 3 weeks ago

@csrwng: This pull request references Jira Issue OCPBUGS-38755, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to [this](https://github.com/openshift/hypershift/pull/4582): >**What this PR does / why we need it**: > - Removes the go.work and go.work.sum files from the repository. > - Updates the Makefile to not use go workspaces. > - Updates the vendored staticcheck so it won't fail on new style range > statements. > - Makes minor fixes flagged by staticcheck > - Adds instructions for setting up a Go workspace in HACKING doc > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes #[OCPBUGS-38755](https://issues.redhat.com/browse/OCPBUGS-38755) > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 3 weeks ago

@csrwng can you try to explain again what was wrong with what you proposed previously? other than go.work and go.work.sum files, which other files will show up as modified that shouldn't be pushed to the repo?

bryan-cox commented 3 weeks ago

/retest

bryan-cox commented 3 weeks ago

/test e2e-aws

csrwng commented 3 weeks ago

can you try to explain again what was wrong with what you proposed previously? other than go.work and go.work.sum files, which other files will show up as modified that shouldn't be pushed to the repo?

The problem is trying to use those go.work files. When you run operations like go work sync and go work vendor you end up with a dirty repository.

bryan-cox commented 3 weeks ago

/lgtm

bryan-cox commented 3 weeks ago

/retest

For konflux

bryan-cox commented 3 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 3 weeks ago

@bryan-cox: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/hypershift/pull/4582#issuecomment-2304970337): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

bryan-cox commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 18bbdb41a47202f410c4bc04df7d6b8c9cc8348d and 2 for PR HEAD d7e15e092ffe82cb06dd07df9ebdb4aba4702bb5 in total

openshift-ci[bot] commented 2 weeks ago

@csrwng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-aks-ovn-conformance	d7e15e092ffe82cb06dd07df9ebdb4aba4702bb5	link	false	`/test e2e-azure-aks-ovn-conformance`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-ci-robot commented 2 weeks ago

@csrwng: Jira Issue OCPBUGS-38755: All pull requests linked via external trackers have merged:

openshift/hypershift#4582

Jira Issue OCPBUGS-38755 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4582): >**What this PR does / why we need it**: > - Removes the go.work and go.work.sum files from the repository. > - Updates the Makefile to not use go workspaces. > - Updates the vendored staticcheck so it won't fail on new style range > statements. > - Makes minor fixes flagged by staticcheck > - Adds instructions for setting up a Go workspace in HACKING doc > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes #[OCPBUGS-38755](https://issues.redhat.com/browse/OCPBUGS-38755) > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-cherrypick-robot commented 2 weeks ago

@bryan-cox: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error message

status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

In response to [this](https://github.com/openshift/hypershift/pull/4582#issuecomment-2304970337): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

LiangquanLi930 commented 2 weeks ago

/jira backport release-4.17

openshift-ci-robot commented 2 weeks ago

@LiangquanLi930: The following backport issues have been created:

OCPBUGS-38967 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.17

In response to [this](https://github.com/openshift/hypershift/pull/4582#issuecomment-2311559413): >/jira backport release-4.17 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-cherrypick-robot commented 2 weeks ago

@openshift-ci-robot: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error message

status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}

In response to [this](https://github.com/openshift/hypershift/pull/4582#issuecomment-2311559566): >@LiangquanLi930: The following backport issues have been created: >- [OCPBUGS-38967](https://issues.redhat.com//browse/OCPBUGS-38967) for branch release-4.17 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.17 > >

> >In response to [this](https://github.com/openshift/hypershift/pull/4582#issuecomment-2311559413): > >>/jira backport release-4.17 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.18.0-202408270610.p0.g0cc82f7.assembly.stream.el9. All builds following this will include this PR.

openshift / hypershift

OCPBUGS-38755: Remove go workspaces from source control #4582