search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
416 stars 309 forks source link

OSASINFRA-3572: e2e/openstack: handle DNS for ingress using route53 #4586

Closed EmilienM closed 2 weeks ago

EmilienM commented 3 weeks ago

This change is only for our CI. Instead of handling the DNS prior to deploy a HostedCluster, we now leverage AWS Route53 service, using the CI credentials to create the *.apps.<cluster-name>.<base-domain> DNS record dynamically. With that work, we'll be able to not only simplify our CI workflow (that used to create a FIP, update DNS, etc), but also to deploy concurrent HostedClusters.

This PR leverages as much as possible the existing functions used by AWS infra to find DNS domains or create a DNS record.

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 3 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack sounds like one of the 2 nodepools didn't come online.

EmilienM commented 2 weeks ago

/test e2e-openstack

netlify[bot] commented 2 weeks ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit baf0f57d589b24c44b3284ba409ad44235f351a3
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66cf359845dc3800083137a9
Deploy Preview https://deploy-preview-4586--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack /retest-required

EmilienM commented 2 weeks ago

the OpenStack job passed, let's see if it's consistent or if we were lucky.

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

Passed again for a 2nd time in a row, trying a third time: /test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack infra issue, not related to any of this.

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

EmilienM commented 2 weeks ago

/test e2e-openstack

csrwng commented 2 weeks ago

/approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [csrwng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
EmilienM commented 2 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 weeks ago

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-4.17 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/hypershift/pull/4586#issuecomment-2316531707): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
MaysaMacedo commented 2 weeks ago

/lgtm

EmilienM commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@EmilienM: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/hypershift/pull/4586#issuecomment-2317715571): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@EmilienM: This pull request references OSASINFRA-3572 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4586): >This change is only for our CI. >Instead of handling the DNS prior to deploy a HostedCluster, we now leverage AWS Route53 service, using the CI credentials to create the `*.apps..` DNS record dynamically. >With that work, we'll be able to not only simplify our CI workflow (that used to create a FIP, update DNS, etc), but also to deploy concurrent HostedClusters. > >This PR leverages as much as possible the existing functions used by AWS infra to find DNS domains or create a DNS record. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
EmilienM commented 2 weeks ago

/test e2e-aks

EmilienM commented 2 weeks ago

/refresh

openshift-cherrypick-robot commented 2 weeks ago

@EmilienM: #4586 failed to apply on top of branch "release-4.17":

Applying: Revert "e2e/util: override CLUSTER_NAME for platform OpenStack"
Applying: openstack: handle DNS for ingress in e2e
Using index info to reconstruct a base tree...
M   test/e2e/util/hypershift_framework.go
M   test/e2e/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/util/util.go
CONFLICT (content): Merge conflict in test/e2e/util/util.go
Auto-merging test/e2e/util/hypershift_framework.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 openstack: handle DNS for ingress in e2e
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/hypershift/pull/4586#issuecomment-2316531707): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
EmilienM commented 2 weeks ago

backport: https://github.com/openshift/hypershift/pull/4644

mdbooth commented 2 weeks ago

Nice!

@EmilienM Did we end up implementing the cleanup @davidvossel pointed out?

EmilienM commented 2 weeks ago

Yes cleanup is done, you should see it in the code and in logs

EmilienM commented 1 week ago

https://github.com/openshift/hypershift/pull/4586/files#diff-cebde6b83b4b372162b2c6a22710a4ab0b1838576120535593a66a3a9bdfc170R1449-R1481