HOSTEDCP-1732: add PDB to sharedIngress router pod

Patryk-Stefanski commented 2 months ago

What this PR does / why we need it: add PDB to sharedIngress router pod

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes # HOSTEDCP-1732

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

openshift-ci-robot commented 2 months ago

@Patryk-Stefanski: This pull request references HOSTEDCP-1732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4596): >**What this PR does / why we need it**: add PDB to sharedIngress router pod > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # [HOSTEDCP-1732](https://issues.redhat.com/browse/HOSTEDCP-1732) > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Patryk-Stefanski commented 2 months ago

/test e2e-azure-aks-ovn-conformance

Patryk-Stefanski commented 2 months ago

/test e2e-azure-aks-ovn-conformance

Patryk-Stefanski commented 2 months ago

/test e2e-aks

Patryk-Stefanski commented 2 months ago

/test e2e-aks

netlify[bot] commented 2 months ago

Deploy Preview for hypershift-docs ready!

Name	Link
Latest commit	f6fd8779b362349cdc50be2268577fcc6ac93d8b
Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/66ed8e4684edb00008c68cee
Deploy Preview	https://deploy-preview-4596--hypershift-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Patryk-Stefanski commented 2 months ago

/test e2e-aks

Patryk-Stefanski commented 2 months ago

/test e2e-aws

Patryk-Stefanski commented 2 months ago

/test e2e-aws

Patryk-Stefanski commented 2 months ago

/test e2e-aws

Patryk-Stefanski commented 1 month ago

Just to be clear, this is hard coding replicas: 2 and PDB maxUnavailable: 1 for the shared ingress deployment created by the HO.

Yep

Patryk-Stefanski commented 1 month ago

/retest-required

bryan-cox commented 1 month ago

/test e2e-aws-4-17

jparrill commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, Patryk-Stefanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

Patryk-Stefanski commented 1 month ago

/retest

Patryk-Stefanski commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@Patryk-Stefanski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-aks-ovn-conformance	58c9197d2160dcf2b6ed81ca073724508432ac2e	link	false	`/test e2e-azure-aks-ovn-conformance`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

sjenning commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD acc4f25f80212c2dad6010a457d15d32e4eb0121 and 2 for PR HEAD 9e2ab5067fb5edfd599a5d4c5ac84e6091a6f6ca in total

openshift / hypershift