search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
416 stars 309 forks source link

OCPBUGS-38921: Set Image as mutable and trigger upgrades on Azure NodePool spec changes #4606

Closed bryan-cox closed 2 weeks ago

bryan-cox commented 3 weeks ago

What this PR does / why we need it: This PR:

Which issue(s) this PR fixes: Fixes OCPBUGS-38921

Checklist

openshift-ci[bot] commented 3 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 3 weeks ago

@bryan-cox: This pull request references Jira Issue OCPBUGS-38921, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4606): >**What this PR does / why we need it**: >This PR: >* lets Image be mutable in Azure NodePools. If Image is not mutable, then there is no way of upgrading the image for an Azure NodePool. >* Uses machineTemplateSpec for Azure in the NodePool controller so changes to the spec trigger NodePool upgrades. > >**Which issue(s) this PR fixes**: >Fixes [OCPBUGS-38921](https://issues.redhat.com/browse/OCPBUGS-38921) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bryan-cox commented 3 weeks ago

/test all

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bryan-cox commented 2 weeks ago

/test all

bryan-cox commented 2 weeks ago

/test all

bryan-cox commented 2 weeks ago

/test all

bryan-cox commented 2 weeks ago

/cherry-pick release-4.17, release-4.16

openshift-cherrypick-robot commented 2 weeks ago

@bryan-cox: once the present PR merges, I will cherry-pick it on top of release-4.17, in a new PR and assign it to you.

In response to [this](https://github.com/openshift/hypershift/pull/4606#issuecomment-2312293894): >/cherry-pick release-4.17, release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bryan-cox commented 2 weeks ago

/test all

bryan-cox commented 2 weeks ago

/retest

bryan-cox commented 2 weeks ago

/test e2e-aks

bryan-cox commented 2 weeks ago

/test e2e-aks

fxierh commented 2 weeks ago

/test e2e-aks

bryan-cox commented 2 weeks ago

/test e2e-aks

netlify[bot] commented 2 weeks ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit ec14922796be87f2887981551838c5abdccf82e5
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66cf4d00ddf47b000865ca58
Deploy Preview https://deploy-preview-4606--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci[bot] commented 2 weeks ago

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-aks-ovn-conformance bc60133f6a8a2128c5e74d4b8b4ca97486084f07 link false /test e2e-azure-aks-ovn-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bryan-cox commented 2 weeks ago

/test e2e-aks

muraee commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

@bryan-cox: Jira Issue OCPBUGS-38921: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38921 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4606): >**What this PR does / why we need it**: >This PR: >* lets Image be mutable in Azure NodePools. If Image is not mutable, then there is no way of upgrading the image for an Azure NodePool. >* Uses machineTemplateSpec for Azure in the NodePool controller so changes to the spec trigger NodePool upgrades. > >**Which issue(s) this PR fixes**: >Fixes [OCPBUGS-38921](https://issues.redhat.com/browse/OCPBUGS-38921) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 weeks ago

@bryan-cox: cannot checkout release-4.17,: error checking out "release-4.17,": exit status 1 error: pathspec 'release-4.17,' did not match any file(s) known to git

In response to [this](https://github.com/openshift/hypershift/pull/4606#issuecomment-2312293894): >/cherry-pick release-4.17, release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bryan-cox commented 2 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 weeks ago

@bryan-cox: new pull request created: #4640

In response to [this](https://github.com/openshift/hypershift/pull/4606#issuecomment-2318859701): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.