openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
425 stars 315 forks source link

NO-JIRA: fix a typo in the architecture doc #4610

Closed devguyio closed 2 months ago

devguyio commented 2 months ago

What this PR does / why we need it: Fix a typo in the controller architecture docs

Checklist

netlify[bot] commented 2 months ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit 2131510d3f2fd761d4b0f340244a9b00cebc792a
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66ccb08876b87c00087070d1
Deploy Preview https://deploy-preview-4610--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bryan-cox commented 2 months ago

/retitle NO-JIRA: fix a typo in the architecture doc /approve /lgtm

openshift-ci-robot commented 2 months ago

@devguyio: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4610): >**What this PR does / why we need it**: >Fix a typo in the controller architecture docs > > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [x] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 0cc82f7b102dcdf6e5d057255be1bdb1593d1203 and 2 for PR HEAD 2131510d3f2fd761d4b0f340244a9b00cebc792a in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 0cc82f7b102dcdf6e5d057255be1bdb1593d1203 and 2 for PR HEAD 2131510d3f2fd761d4b0f340244a9b00cebc792a in total

openshift-ci[bot] commented 2 months ago

@devguyio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-aks-ovn-conformance 2131510d3f2fd761d4b0f340244a9b00cebc792a link false /test e2e-azure-aks-ovn-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 0cc82f7b102dcdf6e5d057255be1bdb1593d1203 and 2 for PR HEAD 2131510d3f2fd761d4b0f340244a9b00cebc792a in total

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.18.0-202408272341.p0.g74077fb.assembly.stream.el9. All builds following this will include this PR.