[release-4.16] OCPBUGS-38726: fix: bump github.com/IBM/go-sdk-core/v5

devguyio commented 2 weeks ago

What this PR does / why we need it:

go-sdk-core v5.17.4 bumps github.com/hashicorp/go-retryablehttp v5.17.2 which is a vulnerable dependecy.

See-also: CVE-2024-6104

Which issue(s) this PR fixes:

Fixes OCPBUGS-38726

Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

expected the bug to target the "4.16.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-38726 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4611): >**What this PR does / why we need it**: >go-sdk-core v5.17.4 bumps github.com/hashicorp/go-retryablehttp v5.17.2 which is a vulnerable dependecy. > > >See-also: CVE-2024-6104 > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes OCPBUGS-38726 > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-38726 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310711310): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-38726 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310750414): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-38725 to target a version in 4.17.0, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310796626): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected dependent Jira Issue OCPBUGS-38725 to target a version in 4.17.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310802578): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310804070): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

sjenning commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@sjenning: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310887512): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

sjenning commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@sjenning: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310889666): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

sjenning commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@sjenning: This pull request references Jira Issue OCPBUGS-38726, which is valid. The bug has been moved to the POST state.

9 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent bug [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * dependent [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2310891625): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 2 weeks ago

@devguyio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is valid.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2311673650): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is valid.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2311676375): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

expected Jira Issue OCPBUGS-38726 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2311677331): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is invalid:

expected Jira Issue OCPBUGS-38726 to depend on a bug targeting a version in 4.17.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2311678773): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@devguyio: This pull request references Jira Issue OCPBUGS-38726, which is valid.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38725](https://issues.redhat.com//browse/OCPBUGS-38725) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2311680693): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/area ci-tooling

sjenning commented 2 weeks ago

/approve /lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.16/OWNERS)~~ [sjenning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci-robot commented 2 weeks ago

@devguyio: Jira Issue OCPBUGS-38726: All pull requests linked via external trackers have merged:

openshift/hypershift#4611

Jira Issue OCPBUGS-38726 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4611): >**What this PR does / why we need it**: > >go-sdk-core v5.17.4 bumps github.com/hashicorp/go-retryablehttp v5.17.2 which is a vulnerable dependecy. > >See-also: CVE-2024-6104 > >**Which issue(s) this PR fixes**: > >Fixes OCPBUGS-38726 > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

devguyio commented 2 weeks ago

/cherry-pick release-4.15 release-4.14

openshift-cherrypick-robot commented 2 weeks ago

@devguyio: #4611 failed to apply on top of branch "release-4.15":

Applying: fix: bump github.com/IBM/go-sdk-core/v5
Using index info to reconstruct a base tree...
M   go.mod
M   go.sum
M   vendor/github.com/IBM/go-sdk-core/v5/core/request_builder.go
A   vendor/github.com/IBM/go-sdk-core/v5/core/sdk_problem_utils.go
M   vendor/github.com/IBM/go-sdk-core/v5/core/version.go
M   vendor/github.com/hashicorp/go-retryablehttp/CHANGELOG.md
M   vendor/github.com/hashicorp/go-retryablehttp/client.go
M   vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/github.com/hashicorp/go-retryablehttp/client.go
Auto-merging vendor/github.com/hashicorp/go-retryablehttp/CHANGELOG.md
CONFLICT (content): Merge conflict in vendor/github.com/hashicorp/go-retryablehttp/CHANGELOG.md
Auto-merging vendor/github.com/IBM/go-sdk-core/v5/core/version.go
CONFLICT (content): Merge conflict in vendor/github.com/IBM/go-sdk-core/v5/core/version.go
CONFLICT (modify/delete): vendor/github.com/IBM/go-sdk-core/v5/core/sdk_problem_utils.go deleted in HEAD and modified in fix: bump github.com/IBM/go-sdk-core/v5. Version fix: bump github.com/IBM/go-sdk-core/v5 of vendor/github.com/IBM/go-sdk-core/v5/core/sdk_problem_utils.go left in tree.
Auto-merging vendor/github.com/IBM/go-sdk-core/v5/core/request_builder.go
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: bump github.com/IBM/go-sdk-core/v5
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to [this](https://github.com/openshift/hypershift/pull/4611#issuecomment-2313283934): >/cherry-pick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

devguyio commented 2 weeks ago

CONFLICT (content): Merge conflict in go.sum Auto-merging go.mod CONFLICT (content): Merge conflict in go.mod

Of course! Duh! My bad 🤦🏽 !

openshift-merge-robot commented 2 weeks ago

Fix included in accepted release 4.16.0-0.nightly-2024-08-28-181245

openshift / hypershift

[release-4.16] OCPBUGS-38726: fix: bump github.com/IBM/go-sdk-core/v5 #4611