openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
416 stars 309 forks source link

[release-4.14] OCPBUGS-38791: Let the CPO oidc check resolve through data plane #4617

Closed enxebre closed 2 weeks ago

enxebre commented 2 weeks ago

Manual cherry-pick of https://github.com/openshift/hypershift/pull/4564 Includes a new commit adding a restMapper parameter for transportForCARef so we can fake tests with this client go version. Otherwise this client go version requires the fake kubeconfig kas address to be a valid serving URL.

openshift-ci-robot commented 2 weeks ago

@enxebre: This pull request references Jira Issue OCPBUGS-38791, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-38561](https://issues.redhat.com//browse/OCPBUGS-38561) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38561](https://issues.redhat.com//browse/OCPBUGS-38561) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (heli@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4617): >Manual cherry-pick of https://github.com/openshift/hypershift/pull/4564 >Includes a new commit adding a restMapper parameter for transportForCARef so we can fake tests with this client go version. Otherwise this client go version requires the fake kubeconfig kas address to be a valid serving URL. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.14/OWNERS)~~ [enxebre] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enxebre commented 2 weeks ago

ERRO[2024-08-27T12:05:08Z] Timed out waiting for image pull secrets in the test namespace. INFO[2024-08-27T12:05:08Z] Ran for 2m0s
ERRO[2024-08-27T12:05:08Z] Some steps failed:
ERRO[2024-08-27T12:05:08Z]

  • could not initialize namespace: timed out waiting for image pull secrets INFO[2024-08-27T12:05:08Z] Reporting job state 'failed' with reason 'initializing_namespace'

/retest

sjenning commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD f036a4dbbb9063f20d31e4a0ad0eba3d04968083 and 2 for PR HEAD 122284ac37907e7d82109471e2838d44c4d22527 in total

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD f036a4dbbb9063f20d31e4a0ad0eba3d04968083 and 2 for PR HEAD 122284ac37907e7d82109471e2838d44c4d22527 in total

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD f036a4dbbb9063f20d31e4a0ad0eba3d04968083 and 2 for PR HEAD 122284ac37907e7d82109471e2838d44c4d22527 in total

bryan-cox commented 2 weeks ago

/retest For konflux

openshift-ci[bot] commented 2 weeks ago

@enxebre: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@enxebre: Jira Issue OCPBUGS-38791: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38791 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4617): >Manual cherry-pick of https://github.com/openshift/hypershift/pull/4564 >Includes a new commit adding a restMapper parameter for transportForCARef so we can fake tests with this client go version. Otherwise this client go version requires the fake kubeconfig kas address to be a valid serving URL. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.