Closed csrwng closed 2 weeks ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csrwng
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/jira cherry-pick OCPBUGS-38755
@csrwng: Detected clone of Jira Issue OCPBUGS-38755 with correct target version. Will retitle the PR to link to the clone. /retitle OCPBUGS-38967: [release-4.17] Remove go workspaces
@csrwng: This pull request references Jira Issue OCPBUGS-38967, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@csrwng: This pull request references Jira Issue OCPBUGS-38967, which is valid. The bug has been moved to the POST state.
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.
/lgtm
Backport of PR https://github.com/openshift/hypershift/pull/4582
/retest-required
Remaining retests: 0 against base HEAD 1827c48af209708896f7a0f74f22a64dec0c4bec and 2 for PR HEAD 67baa6fc805aa4826da3238f146e0d4ccf3bdcab in total
/retest-required
@csrwng: all tests passed!
Full PR test history. Your PR dashboard.
@csrwng: Jira Issue OCPBUGS-38967: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-38967 has been moved to the MODIFIED state.
What this PR does / why we need it: Removes the go.work and go.work.sum files from the repository. Updates the Makefile to not use go workspaces. Updates the vendored staticcheck so it won't fail on new style range statements. Makes minor fixes flagged by staticcheck Adds instructions for setting up a Go workspace in HACKING doc
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story: Fixes #OCPBUGS-38755Checklist