search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
425 stars 315 forks source link

OCPBUGS-39035: Ensure AzureCluster.Status.FailureDomains is populated when any NodePool specifies an Availability Zone #4623

Closed fxierh closed 2 months ago

fxierh commented 2 months ago

Ensure AzureCluster.Status.FailureDomains is populated when any NodePool specifies an Availability Zone.

Otherwise CAPZ will create Azure VMs with both Availability Zone and Availability Set configured, which results in an error:

{
        "error": {
          "code": "BadRequest",
          "message": "Virtual Machine cannot be created because both Availability Zone and Availability Set were specified. Deploying an Availability Set to an Availability Zone isn’t supported."
        }
}

ref: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/711d86187262612c8f7f02f1848c22fbf3b040cd/azure/scope/cluster.go#L778-L780

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fxierh Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@fxierh: This pull request references Jira Issue OCPBUGS-39035, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4623): >Ensure AzureCluster.Status.FailureDomains is populated when any NodePool specifies an Availability Zone. > >Otherwise CAPZ will create Azure VMs with both Availability Zone and Availability Set configured, which results in an error: >```bash >{ > "error": { > "code": "BadRequest", > "message": "Virtual Machine cannot be created because both Availability Zone and Availability Set were specified. Deploying an Availability Set to an Availability Zone isn’t supported." > } >} >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
fxierh commented 2 months ago

/test all

fxierh commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@fxierh: This pull request references Jira Issue OCPBUGS-39035, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @fxierh

In response to [this](https://github.com/openshift/hypershift/pull/4623#issuecomment-2313279474): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: fxierh.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/hypershift/pull/4623#issuecomment-2313279706): >@fxierh: This pull request references [Jira Issue OCPBUGS-39035](https://issues.redhat.com//browse/OCPBUGS-39035), which is valid. The bug has been moved to the POST state. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @fxierh

In response to [this](https://github.com/openshift/hypershift/pull/4623#issuecomment-2313279474): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

fxierh commented 2 months ago

/retest

fxierh commented 2 months ago

/test e2e-aws

openshift-ci[bot] commented 2 months ago

@fxierh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@fxierh: This pull request references Jira Issue OCPBUGS-39035, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @fxierh

In response to [this](https://github.com/openshift/hypershift/pull/4623): >Ensure AzureCluster.Status.FailureDomains is populated when any NodePool specifies an Availability Zone. > >Otherwise CAPZ will create Azure VMs with both Availability Zone and Availability Set configured, which results in an error: >```bash >{ > "error": { > "code": "BadRequest", > "message": "Virtual Machine cannot be created because both Availability Zone and Availability Set were specified. Deploying an Availability Set to an Availability Zone isn’t supported." > } >} >``` > >ref: >https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/711d86187262612c8f7f02f1848c22fbf3b040cd/azure/scope/cluster.go#L778-L780 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: fxierh.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/hypershift/pull/4623#issuecomment-2314894762): >@fxierh: This pull request references [Jira Issue OCPBUGS-39035](https://issues.redhat.com//browse/OCPBUGS-39035), which is valid. > >
3 validation(s) were run on this bug > >* bug is open, matching expected state (open) >* bug target version (4.18.0) matches configured target version for branch (4.18.0) >* bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @fxierh

In response to [this](https://github.com/openshift/hypershift/pull/4623): >Ensure AzureCluster.Status.FailureDomains is populated when any NodePool specifies an Availability Zone. > >Otherwise CAPZ will create Azure VMs with both Availability Zone and Availability Set configured, which results in an error: >```bash >{ > "error": { > "code": "BadRequest", > "message": "Virtual Machine cannot be created because both Availability Zone and Availability Set were specified. Deploying an Availability Set to an Availability Zone isn’t supported." > } >} >``` > >ref: >https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/711d86187262612c8f7f02f1848c22fbf3b040cd/azure/scope/cluster.go#L778-L780 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

enxebre commented 2 months ago

/hold

fxierh commented 2 months ago

Fixed upstream: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5098

/close

openshift-ci[bot] commented 2 months ago

@fxierh: Closed this PR.

In response to [this](https://github.com/openshift/hypershift/pull/4623#issuecomment-2315363584): >Fixed upstream: https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5098 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

@fxierh: This pull request references Jira Issue OCPBUGS-39035. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/hypershift/pull/4623): >Ensure AzureCluster.Status.FailureDomains is populated when any NodePool specifies an Availability Zone. > >Otherwise CAPZ will create Azure VMs with both Availability Zone and Availability Set configured, which results in an error: >```bash >{ > "error": { > "code": "BadRequest", > "message": "Virtual Machine cannot be created because both Availability Zone and Availability Set were specified. Deploying an Availability Set to an Availability Zone isn’t supported." > } >} >``` > >ref: >https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/711d86187262612c8f7f02f1848c22fbf3b040cd/azure/scope/cluster.go#L778-L780 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.