search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
416 stars 309 forks source link

OCPBUGS-39078: e2e: skip VAP checks if platform is None #4629

Closed sjenning closed 2 weeks ago

sjenning commented 2 weeks ago

HCCO installs the admission policies, however, NonePlatform clusters can be ready before the HCCO is fully up and reconciling, resulting in a potential race and flaky test assertions.

openshift-ci-robot commented 2 weeks ago

@sjenning: This pull request references Jira Issue OCPBUGS-39078, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4629): >HCCO installs the admission policies, however, `NonePlatform` clusters can be ready before the HCCO is fully up and reconciling, resulting in a potential race and flaky test assertions. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [sjenning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
muraee commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD e5d525a67b47840a09d5ba55dd258ca1d7f9603a and 2 for PR HEAD b71b57a064cb0eaeca9add74981643aa423c465a in total

openshift-ci[bot] commented 2 weeks ago

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@sjenning: Jira Issue OCPBUGS-39078: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39078 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4629): >HCCO installs the admission policies, however, `NonePlatform` clusters can be ready before the HCCO is fully up and reconciling, resulting in a potential race and flaky test assertions. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.