search

openshift / image-inspector

Apache License 2.0
34 stars 29 forks source link

Add headers to request for CVE file #100

Closed nimrodshn closed 6 years ago

nimrodshn commented 6 years ago

What this does?

Adds headers to the CVE file request under getInputCVE - Some servers require headers in order to supply a 200 response, in particular our default CVE host -https://www.redhat.com/security/data/metrics/ds/

BZ's: https://bugzilla.redhat.com/show_bug.cgi?id=1620376 https://bugzilla.redhat.com/show_bug.cgi?id=1620068

nimrodshn commented 6 years ago

@simon3z @cben @yaacov please review.

simon3z commented 6 years ago

@cben @yaacov, it seems simple enough but could you do a first round of review?

yaacov commented 6 years ago

LGTM, and fixes the issue in the BZ.

nimrodshn commented 6 years ago

@simon3z No it isn't required - Thanks! fixed.

PTAL. :it:

simon3z commented 6 years ago

@nimrodshn LGTM :+1: to merge if you re-tested and it's fixing the issues.

nimrodshn commented 6 years ago

@simon3z tested. :+1:

cben commented 6 years ago

LGTM. @simon3z can you do a release? Can we help do a release? What does releasing involve in this repo?

cben commented 6 years ago

Q: can this be a minor version bump? manageiq only specifies 2.1 docker tag. https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/234 bumps to 2.4 docker tag, still unmerged because we had no bandwidth to test. we'll test it now.

do we want to fix existing manageiqs by backporting and releasing inspector 2.1.3? or backport the manageiq bump to use inspector 2.4 and just release inspector 2.4.1?

(anyway, let's start from inspector 2.4.1, so we can start the downstream build ball rolling...)

simon3z commented 6 years ago

Once you identified which version you intend to build and release please submit the backported PR to the relevant branch. Erez released the last build, do you have anyone in your team left in charge to handle that?

cben commented 6 years ago

testing now via my docker hub...

Erez released the last build, do you have anyone in your team left in charge to handle that?

nshneor sorry the github name is @nimrodshn. Can you give him github & docker hub permissions?

cben commented 6 years ago

sorry the github name is @nimrodshn.

simon3z commented 6 years ago

nshneor sorry the github name is @nimrodshn. Can you give him github & docker hub permissions?

I can't, openshift org admins can. Check with @pweil-

cben commented 6 years ago

@nimrodshn you should now be able to tag v2.4.1