search

openshift / image-inspector

Apache License 2.0
34 stars 29 forks source link

Add integration tests to Travis CI jobs #65

Closed ilackarms closed 7 years ago

ilackarms commented 7 years ago

This PR adds Integration tests will attempt to pull and scan an image without throwing an error. In order to accomplish this with our CI (travis), travis now runs tests inside a docker container (as travis does not support centos-based builds).

The PR also adds a set of integration tests for the WebDAV server (ensures http endpoints behave as expected).

the success of docker build will now also be tested by travis.

The additional tests are implemented with the Ginkgo Test Framework. Ginkgo tests are compatible with go test

ilackarms commented 7 years ago

this PR is based off of #64. the original work and discussion of the changes here are in #61 (now closed)

ilackarms commented 7 years ago

@pweil- @mfojtik PTAL

simon3z commented 7 years ago

@ilackarms overall is good! Just a minor comment. Let me know if you want to handle it, or I can merge as-is. Thanks.

ilackarms commented 7 years ago

excellent! very excited to be able to increase our Travis test coverage