search

openshift / image-registry

OpenShift cluster image registry
Apache License 2.0
44 stars 73 forks source link

Bug 2061785: Fix ICSP for subrepositories #318

Closed dmage closed 2 years ago

dmage commented 2 years ago

Backport of #311 and #312.

openshift-ci[bot] commented 2 years ago

@dmage: This pull request references Bugzilla bug 2014240, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/image-registry/pull/318): >Bug 2014240: Fix ICSP for subrepositories Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@dmage: This pull request references Bugzilla bug 2061785, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/image-registry/pull/318): >Bug 2061785: Fix ICSP for subrepositories Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dmage commented 2 years ago

/assign @flavianmissi

flavianmissi commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/dockerregistry/OWNERS](https://github.com/openshift/image-registry/blob/release-4.10/pkg/dockerregistry/OWNERS)~~ [dmage] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

xiuwang commented 2 years ago

/label qe-approved

openshift-ci[bot] commented 2 years ago

@dmage: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 years ago

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci[bot] commented 2 years ago

@openshift-bot: This pull request references Bugzilla bug 2061785, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/image-registry/pull/318#issuecomment-1063535952): >/bugzilla refresh > >Recalculating validity in case the underlying Bugzilla bug has changed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 years ago

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci[bot] commented 2 years ago

@openshift-bot: This pull request references Bugzilla bug 2061785, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.z) matches configured target release for branch (4.10.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 2014240](https://bugzilla.redhat.com/show_bug.cgi?id=2014240) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 2014240](https://bugzilla.redhat.com/show_bug.cgi?id=2014240) targets the "4.11.0" release, which is one of the valid target releases: 4.11.0 * bug has dependents

Requesting review from QA contact: /cc @xiuwang

In response to [this](https://github.com/openshift/image-registry/pull/318#issuecomment-1064666618): >/bugzilla refresh > >Recalculating validity in case the underlying Bugzilla bug has changed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xiuwang commented 2 years ago

/label cherry-pick-approved

dmage commented 2 years ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 years ago

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 2061785 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/image-registry/pull/318): >Bug 2061785: Fix ICSP for subrepositories Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dmage commented 2 years ago

/cherrypick release-4.9

openshift-cherrypick-robot commented 2 years ago

@dmage: new pull request created: #333

In response to [this](https://github.com/openshift/image-registry/pull/318#issuecomment-1127928534): >/cherrypick release-4.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.