openshift / image-registry

OpenShift cluster image registry
Apache License 2.0
45 stars 75 forks source link

Bug 2069807: Bug 2060362: Revert "Support authentication using gcp workload identity federation" #321

Closed dmage closed 2 years ago

dmage commented 2 years ago

Backport of #320.

openshift-ci[bot] commented 2 years ago

@dmage: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/image-registry/pull/321): >Revert "Support authentication using gcp workload identity federation" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@dmage: This pull request references Bugzilla bug 2069807, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.z) matches configured target release for branch (4.10.z) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 2065689](https://bugzilla.redhat.com/show_bug.cgi?id=2065689) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 2065689](https://bugzilla.redhat.com/show_bug.cgi?id=2065689) targets the "4.11.0" release, which is one of the valid target releases: 4.11.0 * bug has dependents

Requesting review from QA contact: /cc @xiuwang

In response to [this](https://github.com/openshift/image-registry/pull/321): >Bug 2069807: Revert "Support authentication using gcp workload identity federation" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dmage commented 2 years ago

/label backport-risk-assessed

dmage commented 2 years ago

/assign @flavianmissi

openshift-ci[bot] commented 2 years ago

@dmage: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/image-registry/pull/321): >Bug 2069807, 2060362: Revert "Support authentication using gcp workload identity federation" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@dmage: This pull request references Bugzilla bug 2069807, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.z) matches configured target release for branch (4.10.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 2065689](https://bugzilla.redhat.com/show_bug.cgi?id=2065689) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 2065689](https://bugzilla.redhat.com/show_bug.cgi?id=2065689) targets the "4.11.0" release, which is one of the valid target releases: 4.11.0 * bug has dependents

Requesting review from QA contact: /cc @xiuwang

In response to [this](https://github.com/openshift/image-registry/pull/321): >Bug 2069807: Bug 2060362: Revert "Support authentication using gcp workload identity federation" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
deads2k commented 2 years ago

/lgtm

xiuwang commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@xiuwang: This pull request references Bugzilla bug 2069807, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.z) matches configured target release for branch (4.10.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST) * dependent bug [Bugzilla bug 2065689](https://bugzilla.redhat.com/show_bug.cgi?id=2065689) is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE)) * dependent [Bugzilla bug 2065689](https://bugzilla.redhat.com/show_bug.cgi?id=2065689) targets the "4.11.0" release, which is one of the valid target releases: 4.11.0 * bug has dependents

Requesting review from QA contact: /cc @yyou12

In response to [this](https://github.com/openshift/image-registry/pull/321#issuecomment-1082534945): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
flavianmissi commented 2 years ago

/lgtm

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, dmage, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/image-registry/blob/release-4.10/OWNERS)~~ [dmage] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 years ago

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci[bot] commented 2 years ago

@dmage: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yyou12 commented 2 years ago

/label qe-approved

xiuwang commented 2 years ago

/label cherry-pick-approved

openshift-ci[bot] commented 2 years ago

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 2069807 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/image-registry/pull/321): >Bug 2069807: Bug 2060362: Revert "Support authentication using gcp workload identity federation" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.