search

openshift / image-registry

OpenShift cluster image registry
Apache License 2.0
45 stars 75 forks source link

OCPBUGS-36521: Rename Dockerfile #407

Closed ashwindasr closed 3 months ago

ashwindasr commented 4 months ago

Refactor name to Dockerfile.ocp as a better, version independent, alternative since contents are actually rhel9.

CI: https://github.com/openshift/release/pull/53995 (probably needs to merge first)

Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge.

openshift-ci-robot commented 4 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36521, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @xiuwang

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/image-registry/pull/407): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/53995 > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fimage-registry). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 months ago

@ashwindasr: This pull request references Jira Issue OCPBUGS-36521, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @xiuwang

In response to [this](https://github.com/openshift/image-registry/pull/407): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/53995 (probably needs to merge first) > >Please follow up with other changes in this/other repos if necessary. ART has setup the necessary [fallbacks](https://github.com/openshift-eng/ocp-build-data/pull/5039), but only for 4.17, if backporting this PR, please give us a heads up. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fimage-registry). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
xiuwang commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@xiuwang: This pull request references Jira Issue OCPBUGS-36521, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @wewang58

In response to [this](https://github.com/openshift/image-registry/pull/407#issuecomment-2207855724): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fimage-registry). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
wewang58 commented 4 months ago

/label qe-approved

wewang58 commented 4 months ago

/retest

ashwindasr commented 3 months ago

@adambkaplan @gabemontero In the other components that we had the same issue, we merged the release PR first and then ran /retest here which made tests pass. Not sure if we can try this here as well, unless I'm missing something.

This PR description lists the other upstream PRs that ART has raised.

ashwindasr commented 3 months ago

/hold

Needs to merge with an ocp-build-data PR

flavianmissi commented 3 months ago

release PR merged. /retest

openshift-ci[bot] commented 3 months ago

@ashwindasr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
flavianmissi commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashwindasr, flavianmissi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/image-registry/blob/master/OWNERS)~~ [flavianmissi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ashwindasr commented 3 months ago

/unhold

openshift-ci-robot commented 3 months ago

@ashwindasr: Jira Issue OCPBUGS-36521: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36521 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/image-registry/pull/407): >Refactor name to `Dockerfile.ocp` as a better, version independent, alternative since contents are actually rhel9. > >CI: https://github.com/openshift/release/pull/53995 (probably needs to merge first) > >Please follow up with other changes in this/other repos if necessary. Please reach out to ART once this PR is ready to merge. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fimage-registry). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-registry This PR has been included in build openshift-enterprise-registry-container-v4.17.0-202407221718.p0.g134be6f.assembly.stream.el9. All builds following this will include this PR.