openshift / ingress-node-firewall

Ingress node firewall implements Kubernetes operator to provision stateless ingress node level firewall rules, stateless ingress node firewall implementation is done using eBPF XDP kernel plugin
Apache License 2.0
48 stars 25 forks source link

SDN-5061: intg INFW with bpfman #536

Closed msherif1234 closed 3 months ago

msherif1234 commented 4 months ago

- What this PR does and why is it needed Add option to use bpfman operator to manage INFW ebpf programs

Note: this PR has only XDP hook , TCX will be added once support is in place

openshift-ci-robot commented 4 months ago

@msherif1234: This pull request references SDN-5061 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/ingress-node-firewall/pull/536): >**- What this PR does and why is it needed** >Add option to use bpfman operator to manage INFW ebpf programs > >Note: >this PR has only XDP hook , TCX will be added once support is in place > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fingress-node-firewall). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
msherif1234 commented 4 months ago

/retest

msherif1234 commented 4 months ago

cc'd @astoycos

msherif1234 commented 4 months ago

/retest

msherif1234 commented 4 months ago

/test ingress-node-firewall-e2e-metal-ipi

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/test unit-test

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/test ingress-node-firewall-e2e-metal-ipi

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/test unit-test

msherif1234 commented 3 months ago

/retest

msherif1234 commented 3 months ago

/ok-to-test

msherif1234 commented 3 months ago

/assign @frobware

msherif1234 commented 3 months ago

/test ingress-node-firewall-e2e-metal-ipi

msherif1234 commented 3 months ago

/retest

openshift-ci[bot] commented 3 months ago

@msherif1234: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 3 months ago

@anfredette: changing LGTM is restricted to collaborators

In response to [this](https://github.com/openshift/ingress-node-firewall/pull/536#pullrequestreview-2210368657): >/LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anfredette, msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ingress-node-firewall/blob/master/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
msherif1234 commented 3 months ago

/hold

msherif1234 commented 3 months ago

/hold cancel

frobware commented 3 months ago

/LGTM

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ingress-node-firewall-operator This PR has been included in build ingress-node-firewall-operator-container-v4.18.0-202407311846.p0.ga7252e4.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ingress-node-firewall-daemon This PR has been included in build ingress-node-firewall-daemon-container-v4.18.0-202407311846.p0.ga7252e4.assembly.stream.el9. All builds following this will include this PR.