search

openshift / ingress-node-firewall

Ingress node firewall implements Kubernetes operator to provision stateless ingress node level firewall rules, stateless ingress node firewall implementation is done using eBPF XDP kernel plugin
Apache License 2.0
48 stars 25 forks source link

OCPBUGS-39514: Updating ingress-node-firewall-daemon-container image to be consistent with ART for 4.18 #553

Closed openshift-bot closed 2 months ago

openshift-bot commented 2 months ago

Updating ingress-node-firewall-daemon-container image to be consistent with ART for 4.18 TLDR: Product builds by ART can be configured for different base and builder images than corresponding CI builds. This automated PR requests a change to CI configuration to align with ART's configuration; please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request: ingress-node-firewall-daemon.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI configuration for at least one image differs from ART's expected product configuration. This should be addressed to ensure that the component's CI testing accurate reflects what customers will experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a different version, usually prior to GA. The intent is to effect changes in both configurations simultaneously without breaking either CI or ART builds, so usually ART builds are configured to consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may also configure changes in GA releases with CI remaining canonical for a brief grace period to enable CI to succeed and the alignment PR to merge. In either case, ART configuration will be made canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to change the number of builder images or to use a different golang version. These changes should be coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated first to enable the changes to occur simultaneously in both CI and ART at the same time. This also gives ART a chance to validate the intended changes first. For instance, ART compiles most components with the Golang version being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift staff engineers and communicated to the ART team.

Roles & Responsibilities:

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

Change behavior of future PRs:

If you have any questions about this pull request, please reach out to @release-artists in the #forum-ocp-art coreos slack channel.

openshift-bot commented 2 months ago

Created by job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/scheduled-builds/job/sync-ci-images/14226

openshift-ci-robot commented 2 months ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-39514, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/ingress-node-firewall/pull/553): >Updating ingress-node-firewall-daemon-container image to be consistent with ART for 4.18 >__TLDR__: >Product builds by ART can be configured for different base and builder images than corresponding CI >builds. This automated PR requests a change to CI configuration to align with ART's configuration; >please take steps to merge it quickly or contact ART to coordinate changes. > >The configuration in the following ART component metadata is driving this alignment request: >[ingress-node-firewall-daemon.yml](https://github.com/openshift/ocp-build-data/tree/827ab4ccce9cbbcf82c9dbaf6398b61d6cff8d7a/images/ingress-node-firewall-daemon.yml). > >__Detail__: > >This repository is out of sync with the downstream product builds for this component. The CI >configuration for at least one image differs from ART's expected product configuration. This should >be addressed to ensure that the component's CI testing accurate reflects what customers will >experience. > >Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a >different version, usually prior to GA. The intent is to effect changes in both configurations >simultaneously without breaking either CI or ART builds, so usually ART builds are configured to >consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may >also configure changes in GA releases with CI remaining canonical for a brief grace period to enable >CI to succeed and the alignment PR to merge. In either case, ART configuration will be made >canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is >important to align CI configuration as soon as possible. > >PRs are also triggered when CI configuration changes without ART coordination, for instance to >change the number of builder images or to use a different golang version. These changes should be >coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated >first to enable the changes to occur simultaneously in both CI and ART at the same time. This also >gives ART a chance to validate the intended changes first. For instance, ART compiles most >components with the Golang version being used by the control plane for a given OpenShift release. >Exceptions to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift staff engineers and >communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- In particular, it could be that a job like `verify-deps` is complaining. In that case, please open > a new PR with the dependency issues addressed (and base images bumped). [ART-9595](https://issues.redhat.com//browse/ART-9595) for reference. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. In cases where ART config is > canonical, downstream builds are *already* being built with these changes, and merging this PR > only improves the fidelity of our CI. In cases where ART config is not canonical, this provides > a grace period for the component team to align their CI with ART's configuration before it becomes > canonical in product builds. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >__Change behavior of future PRs__: >* In case you just want to follow the base images that ART suggests, you can configure additional labels to be > set up automatically. This means that such a PR would *merge without human intervention* (and awareness!) in the future. > To do so, open a PR to set the `auto_label` attribute in the image configuration. [Example](https://github.com/openshift-eng/ocp-build-data/pull/1778) >* You can set a commit prefix, like `UPSTREAM: : `. [An example](https://github.com/openshift-eng/ocp-build-data/blob/6831b59dddc5b63282076d3abe04593ad1945148/images/ose-cluster-api.yml#L11). > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fingress-node-firewall). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-39514, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @anuragthehatter

In response to [this](https://github.com/openshift/ingress-node-firewall/pull/553): >Updating ingress-node-firewall-daemon-container image to be consistent with ART for 4.18 >__TLDR__: >Product builds by ART can be configured for different base and builder images than corresponding CI >builds. This automated PR requests a change to CI configuration to align with ART's configuration; >please take steps to merge it quickly or contact ART to coordinate changes. > >The configuration in the following ART component metadata is driving this alignment request: >[ingress-node-firewall-daemon.yml](https://github.com/openshift/ocp-build-data/tree/827ab4ccce9cbbcf82c9dbaf6398b61d6cff8d7a/images/ingress-node-firewall-daemon.yml). > >__Detail__: > >This repository is out of sync with the downstream product builds for this component. The CI >configuration for at least one image differs from ART's expected product configuration. This should >be addressed to ensure that the component's CI testing accurate reflects what customers will >experience. > >Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a >different version, usually prior to GA. The intent is to effect changes in both configurations >simultaneously without breaking either CI or ART builds, so usually ART builds are configured to >consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may >also configure changes in GA releases with CI remaining canonical for a brief grace period to enable >CI to succeed and the alignment PR to merge. In either case, ART configuration will be made >canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is >important to align CI configuration as soon as possible. > >PRs are also triggered when CI configuration changes without ART coordination, for instance to >change the number of builder images or to use a different golang version. These changes should be >coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated >first to enable the changes to occur simultaneously in both CI and ART at the same time. This also >gives ART a chance to validate the intended changes first. For instance, ART compiles most >components with the Golang version being used by the control plane for a given OpenShift release. >Exceptions to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift staff engineers and >communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- In particular, it could be that a job like `verify-deps` is complaining. In that case, please open > a new PR with the dependency issues addressed (and base images bumped). [ART-9595](https://issues.redhat.com//browse/ART-9595) for reference. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. In cases where ART config is > canonical, downstream builds are *already* being built with these changes, and merging this PR > only improves the fidelity of our CI. In cases where ART config is not canonical, this provides > a grace period for the component team to align their CI with ART's configuration before it becomes > canonical in product builds. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >__Change behavior of future PRs__: >* In case you just want to follow the base images that ART suggests, you can configure additional labels to be > set up automatically. This means that such a PR would *merge without human intervention* (and awareness!) in the future. > To do so, open a PR to set the `auto_label` attribute in the image configuration. [Example](https://github.com/openshift-eng/ocp-build-data/pull/1778) >* You can set a commit prefix, like `UPSTREAM: : `. [An example](https://github.com/openshift-eng/ocp-build-data/blob/6831b59dddc5b63282076d3abe04593ad1945148/images/ose-cluster-api.yml#L11). > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fingress-node-firewall). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
msherif1234 commented 2 months ago

/lgtm /approve

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/ingress-node-firewall/blob/master/OWNERS)~~ [msherif1234] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@openshift-bot: Jira Issue OCPBUGS-39514: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39514 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/ingress-node-firewall/pull/553): >Updating ingress-node-firewall-daemon-container image to be consistent with ART for 4.18 >__TLDR__: >Product builds by ART can be configured for different base and builder images than corresponding CI >builds. This automated PR requests a change to CI configuration to align with ART's configuration; >please take steps to merge it quickly or contact ART to coordinate changes. > >The configuration in the following ART component metadata is driving this alignment request: >[ingress-node-firewall-daemon.yml](https://github.com/openshift/ocp-build-data/tree/827ab4ccce9cbbcf82c9dbaf6398b61d6cff8d7a/images/ingress-node-firewall-daemon.yml). > >__Detail__: > >This repository is out of sync with the downstream product builds for this component. The CI >configuration for at least one image differs from ART's expected product configuration. This should >be addressed to ensure that the component's CI testing accurate reflects what customers will >experience. > >Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a >different version, usually prior to GA. The intent is to effect changes in both configurations >simultaneously without breaking either CI or ART builds, so usually ART builds are configured to >consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may >also configure changes in GA releases with CI remaining canonical for a brief grace period to enable >CI to succeed and the alignment PR to merge. In either case, ART configuration will be made >canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is >important to align CI configuration as soon as possible. > >PRs are also triggered when CI configuration changes without ART coordination, for instance to >change the number of builder images or to use a different golang version. These changes should be >coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated >first to enable the changes to occur simultaneously in both CI and ART at the same time. This also >gives ART a chance to validate the intended changes first. For instance, ART compiles most >components with the Golang version being used by the control plane for a given OpenShift release. >Exceptions to this convention (i.e. you believe your component must be compiled with a Golang >version independent from the control plane) must be granted by the OpenShift staff engineers and >communicated to the ART team. > >__Roles & Responsibilities__: >- Component owners are responsible for ensuring these alignment PRs merge with passing > tests OR that necessary metadata changes are reported to the ART team: `@release-artists` > in `#forum-ocp-art` on Slack. If necessary, the changes required by this pull request can be > introduced with a separate PR opened by the component team. Once the repository is aligned, > this PR will be closed automatically. >- In particular, it could be that a job like `verify-deps` is complaining. In that case, please open > a new PR with the dependency issues addressed (and base images bumped). [ART-9595](https://issues.redhat.com//browse/ART-9595) for reference. >- Patch-manager or those with sufficient privileges within this repository may add > any required labels to ensure the PR merges once tests are passing. In cases where ART config is > canonical, downstream builds are *already* being built with these changes, and merging this PR > only improves the fidelity of our CI. In cases where ART config is not canonical, this provides > a grace period for the component team to align their CI with ART's configuration before it becomes > canonical in product builds. > >ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). >In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file: >``` >build_root: > from_repository: true >``` > >__Change behavior of future PRs__: >* In case you just want to follow the base images that ART suggests, you can configure additional labels to be > set up automatically. This means that such a PR would *merge without human intervention* (and awareness!) in the future. > To do so, open a PR to set the `auto_label` attribute in the image configuration. [Example](https://github.com/openshift-eng/ocp-build-data/pull/1778) >* You can set a commit prefix, like `UPSTREAM: : `. [An example](https://github.com/openshift-eng/ocp-build-data/blob/6831b59dddc5b63282076d3abe04593ad1945148/images/ose-cluster-api.yml#L11). > >If you have any questions about this pull request, please reach out to `@release-artists` in the `#forum-ocp-art` coreos slack channel. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fingress-node-firewall). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ingress-node-firewall-operator This PR has been included in build ingress-node-firewall-operator-container-v4.18.0-202409041514.p0.g4d63654.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ingress-node-firewall-daemon This PR has been included in build ingress-node-firewall-daemon-container-v4.18.0-202409041514.p0.g4d63654.assembly.stream.el9. All builds following this will include this PR.