openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

[release-4.17] OCPBUGS-43800: pkg/asset/installconfig/azure: send full certifcate chain #9140

Closed openshift-cherrypick-robot closed 2 hours ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #9117

/assign patrickdillon

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43567 has been cloned as Jira Issue OCPBUGS-43800. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-43800: pkg/asset/installconfig/azure: send full certifcate chain

In response to [this](https://github.com/openshift/installer/pull/9140): >This is an automated cherry-pick of #9117 > >/assign patrickdillon Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-43800, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9140): >This is an automated cherry-pick of #9117 > >/assign patrickdillon Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack af2f9df31958e5f52302ceecd68cd742caf17c73 link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sadasu commented 1 week ago

/approve

sadasu commented 1 week ago

/label backport-risk-assessed

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/asset/installconfig/azure/OWNERS](https://github.com/openshift/installer/blob/release-4.17/pkg/asset/installconfig/azure/OWNERS)~~ [sadasu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gpei commented 6 days ago

/label cherry-pick-approved

sadasu commented 5 days ago

/jira refresh

openshift-ci-robot commented 5 days ago

@sadasu: This pull request references Jira Issue OCPBUGS-43800, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-43567](https://issues.redhat.com//browse/OCPBUGS-43567) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-43567](https://issues.redhat.com//browse/OCPBUGS-43567) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @jinyunma

In response to [this](https://github.com/openshift/installer/pull/9140#issuecomment-2488706549): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sadasu commented 5 days ago

@patrickdillon , @jhixson74 , this needs a LGTM

sadasu commented 10 hours ago

/lgtm

openshift-ci-robot commented 10 hours ago

/retest-required

Remaining retests: 0 against base HEAD 7cb16acc3ca366e4ca28f3f2dc836df77ccd08aa and 2 for PR HEAD af2f9df31958e5f52302ceecd68cd742caf17c73 in total

openshift-ci-robot commented 2 hours ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43800: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43800 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9140): >This is an automated cherry-pick of #9117 > >/assign patrickdillon Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.