search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-44167: Ensure rendezvousIP is checked against host IP #9167

Closed bfournie closed 2 weeks ago

bfournie commented 3 weeks ago

The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP.

openshift-ci-robot commented 3 weeks ago

@bfournie: No Jira issue with key sOCPBUGS-44167 exists in the tracker at https://issues.redhat.com/. Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to [this](https://github.com/openshift/installer/pull/9167): >The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@bfournie: This pull request references Jira Issue OCPBUGS-44167, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9167): >The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bfournie commented 3 weeks ago

/retest

bfournie commented 3 weeks ago

/retest

andfasano commented 2 weeks ago

/approve

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[pkg/asset/agent/OWNERS](https://github.com/openshift/installer/blob/master/pkg/asset/agent/OWNERS)~~ [andfasano] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pawanpinjarkar commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD c0938914effb0f416d01f250ea021de0cea0d690 and 2 for PR HEAD 2f10e807d9677d5dde5a842f14dbf2745f063d10 in total

openshift-ci[bot] commented 2 weeks ago

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@bfournie: Jira Issue OCPBUGS-44167: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44167 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9167): >The rendezvousIP is currently checked against any substring in the nmstate configuration which can result in validation failure if the next-hop-address matches the rendezvousIP. Ensure that the check is against the host IP. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
bfournie commented 2 weeks ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 2 weeks ago

@bfournie: #9167 failed to apply on top of branch "release-4.17":

Applying: OCPBUGS-44167: Ensure rendezvousIP is checked against host IP
Using index info to reconstruct a base tree...
M   pkg/asset/agent/common.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/asset/agent/common.go
CONFLICT (content): Merge conflict in pkg/asset/agent/common.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-44167: Ensure rendezvousIP is checked against host IP
In response to [this](https://github.com/openshift/installer/pull/9167#issuecomment-2458226422): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411052208.p0.g24f72f0.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202411052208.p0.g24f72f0.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.18.0-202411052208.p0.g24f72f0.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.18.0-202411052208.p0.g24f72f0.assembly.stream.el9. All builds following this will include this PR.