Open stephenfin opened 2 weeks ago
@stephenfin: This pull request references OSASINFRA-3657 which is a valid jira issue.
@stephenfin: This pull request references OSASINFRA-3657 which is a valid jira issue.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign r4f4 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@stephenfin: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-openstack-ovn | 5e359c0dbce90c7f7d597a2c81ee46c883bdc74d | link | true | /test e2e-openstack-ovn |
ci/prow/e2e-openstack-nfv-intel | 5e359c0dbce90c7f7d597a2c81ee46c883bdc74d | link | false | /test e2e-openstack-nfv-intel |
ci/prow/e2e-aws-ovn | 5e359c0dbce90c7f7d597a2c81ee46c883bdc74d | link | true | /test e2e-aws-ovn |
ci/prow/e2e-openstack-proxy | 5e359c0dbce90c7f7d597a2c81ee46c883bdc74d | link | false | /test e2e-openstack-proxy |
Full PR test history. Your PR dashboard.
/hold
Will wait for 4.19 for this.
If a CA bundle is required to talk to your OpenStack then obviously all services that talk to the cloud need to have both credentials and said bundle. Currently, these users can get their credentials via cloud credential operator, but they need to source their CA bundle from elsewhere (typically by extracting it from the cloud controller manager's configuration). This makes configuration of services more complicated than necessary.
Continue the resolution of the issue by storing the CA bundle, if any, in the root secret on OpenStack. When coupled with the changes introduced in openshift/cloud-credential-operator#780, this allows us to dole out the bundle to anyone who asks for it via a
CredentialsRequest
.While we're here, we also tweak the configuration for the cloud provider to (a) start generating the configuration file in the new format expected by
cluster-cloud-controller-manager-operator
and (b) stop generating an old secret that only the old, now-removed in-tree OpenStack cloud provider needed and used.