openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

No-Issue: Temporarily set none authenticator #9198

Closed pawanpinjarkar closed 1 week ago

openshift-ci-robot commented 1 week ago

@pawanpinjarkar: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/installer/pull/9198): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sadasu commented 1 week ago

/lgtm

pawanpinjarkar commented 1 week ago

/hold

pawanpinjarkar commented 1 week ago

/hold cancel

zaneb commented 1 week ago

An alternative approach (that avoids disabling auth altogether) would be to add something like https://github.com/zaneb/openshift-installer/commit/authz-compat to #9039 to allow both PRs to merge, and then revert that patch again.

pawanpinjarkar commented 1 week ago

An alternative approach (that avoids disabling auth altogether) would be to add something like zaneb@authz-compat to #9039 to allow both PRs to merge, and then revert that patch again.

Thank you @zaneb for the patch. I successfully tested openshift/installer PR #9198 together with the assisted-service authorization PR #6784, and the cluster installed without issues.

With PR #9198, the changes we’ll need to revert are minimal. Since we’re using the none authenticator, the new authorization PR in assisted-service doesn’t require a value for USER_AUTH_TYPE; it defaults to empty. This prevents any authentication or authorization code from running, as these flows are temporarily disabled, allowing the cluster installation to complete successfully.

openshift-ci[bot] commented 1 week ago

@pawanpinjarkar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bfournie commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[data/data/agent/OWNERS](https://github.com/openshift/installer/blob/master/data/data/agent/OWNERS)~~ [bfournie] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411130408.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202411130407.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.18.0-202411130408.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.19.0-202411130407.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.