Closed pawanpinjarkar closed 1 week ago
/lgtm
/hold
/hold cancel
An alternative approach (that avoids disabling auth altogether) would be to add something like https://github.com/zaneb/openshift-installer/commit/authz-compat to #9039 to allow both PRs to merge, and then revert that patch again.
An alternative approach (that avoids disabling auth altogether) would be to add something like zaneb@authz-compat to #9039 to allow both PRs to merge, and then revert that patch again.
Thank you @zaneb for the patch. I successfully tested openshift/installer PR #9198 together with the assisted-service authorization PR #6784, and the cluster installed without issues.
With PR #9198, the changes we’ll need to revert are minimal. Since we’re using the none authenticator, the new authorization PR in assisted-service doesn’t require a value for USER_AUTH_TYPE; it defaults to empty. This prevents any authentication or authorization code from running, as these flows are temporarily disabled, allowing the cluster installation to complete successfully.
@pawanpinjarkar: all tests passed!
Full PR test history. Your PR dashboard.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bfournie
The full list of commands accepted by this bot can be found here.
The pull request process is described here
[ART PR BUILD NOTIFIER]
Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411130408.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202411130407.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.18.0-202411130408.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.19.0-202411130407.p0.gfd26ad8.assembly.stream.el9. All builds following this will include this PR.
@pawanpinjarkar: This pull request explicitly references no jira issue.