openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

CORS-3754: AWS: With UserProvisionedDNS, keep resolv.conf on the bootstrap node updated #9207

Closed sadasu closed 5 days ago

sadasu commented 1 week ago

When UserProvisionedDNS is enabled during an install on AWS, prepend the NetworkManager generated resolv.conf file on the bootstrap node with the IP of the localhost.

openshift-ci-robot commented 1 week ago

@sadasu: This pull request references CORS-3754 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/installer/pull/9207): >When UserProvisionedDNS is enabled during an install on AWS, prepend the NetworkManager generated resolv.conf file on the bootstrap node with the IP of the localhost. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sadasu commented 1 week ago

/jira refresh

openshift-ci-robot commented 1 week ago

@sadasu: This pull request references CORS-3754 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/installer/pull/9207#issuecomment-2477150692): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sadasu commented 1 week ago

/test e2e-metal-ipi-ovn

sadasu commented 6 days ago

/test e2e-metal-ipi-ovn

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [barbacbd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sadasu commented 6 days ago

/retest-required

sadasu commented 6 days ago

/retest

patrickdillon commented 5 days ago

/lgtm /label acknowledge-critical-fixes-only

openshift-ci-robot commented 5 days ago

/retest-required

Remaining retests: 0 against base HEAD 7eac6a1ef83eeefbc6059222fe185ec2105372b7 and 2 for PR HEAD 49595914caa0a7082435cecc1eeb71844e6c7274 in total

openshift-ci[bot] commented 5 days ago

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones 49595914caa0a7082435cecc1eeb71844e6c7274 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-single-node 49595914caa0a7082435cecc1eeb71844e6c7274 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 5 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.19.0-202411200537.p0.g64d1633.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 5 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.19.0-202411200537.p0.g64d1633.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 5 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.19.0-202411200537.p0.g64d1633.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 5 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.19.0-202411200537.p0.g64d1633.assembly.stream.el9. All builds following this will include this PR.