search

openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-44611: [release-4.17] capi/aws: set Node Port Service CIDR override #9209

Closed r4f4 closed 3 days ago

r4f4 commented 1 week ago

If we don't, CAPA will use "0.0.0.0/0", which is too permissive. Let's use the cluster's CIDR block instead.

Manual cherry-pick of https://github.com/openshift/installer/pull/9127

r4f4 commented 1 week ago

/jira cherrypick OCPBUGS-43048

openshift-ci-robot commented 1 week ago

@r4f4: Jira Issue OCPBUGS-43048 has been cloned as Jira Issue OCPBUGS-44611. Will retitle bug to link to clone. /retitle OCPBUGS-44611: [release-4.17] capi/aws: set Node Port Service CIDR override

In response to [this](https://github.com/openshift/installer/pull/9209#issuecomment-2478854610): >/jira cherrypick OCPBUGS-43048 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@r4f4: This pull request references Jira Issue OCPBUGS-44611, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9209): >If we don't, CAPA will use "0.0.0.0/0", which is too permissive. Let's use the cluster's CIDR block instead. > >Manual cherry-pick of https://github.com/openshift/installer/pull/9127 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

@r4f4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-imdsv2 d8235bcc3bb007649cae07914b0512d7de6774f0 link false /test e2e-aws-ovn-imdsv2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sadasu commented 1 week ago

/label backport-risk-assessed

sadasu commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/release-4.17/OWNERS)~~ [sadasu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gpei commented 6 days ago

/label cherry-pick-approved

r4f4 commented 3 days ago

/jira refresh

openshift-ci-robot commented 3 days ago

@r4f4: This pull request references Jira Issue OCPBUGS-44611, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-43048](https://issues.redhat.com//browse/OCPBUGS-43048) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-43048](https://issues.redhat.com//browse/OCPBUGS-43048) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @gpei

In response to [this](https://github.com/openshift/installer/pull/9209#issuecomment-2493404699): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 days ago

@r4f4: Jira Issue OCPBUGS-44611: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44611 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9209): >If we don't, CAPA will use "0.0.0.0/0", which is too permissive. Let's use the cluster's CIDR block instead. > >Manual cherry-pick of https://github.com/openshift/installer/pull/9127 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.17.0-202411221204.p0.g147f4d9.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.17.0-202411221204.p0.g147f4d9.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202411221204.p0.g147f4d9.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 3 days ago

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.17.0-202411221204.p0.g147f4d9.assembly.stream.el9. All builds following this will include this PR.