openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

Add unit tests for add-nodes workflow related to auth tokens #9218

Open pawanpinjarkar opened 6 days ago

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from pawanpinjarkar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/agent/OWNERS](https://github.com/openshift/installer/blob/master/pkg/agent/OWNERS)** - **[pkg/asset/agent/OWNERS](https://github.com/openshift/installer/blob/master/pkg/asset/agent/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 days ago

New changes are detected. LGTM label has been removed.

rwsu commented 5 days ago

/test e2e-agent-compact-ipv4

andfasano commented 5 days ago

Please add in the description "Requires https://github.com/openshift/installer/pull/9210"

openshift-ci[bot] commented 5 days ago

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-ha-dualstack 314e71bcf2fe84f3fe2bce0de59f7c7e3993442c link false /test e2e-agent-ha-dualstack
ci/prow/e2e-agent-4control-ipv4 314e71bcf2fe84f3fe2bce0de59f7c7e3993442c link false /test e2e-agent-4control-ipv4
ci/prow/e2e-agent-compact-ipv4-appliance-diskimage 314e71bcf2fe84f3fe2bce0de59f7c7e3993442c link false /test e2e-agent-compact-ipv4-appliance-diskimage
ci/prow/okd-scos-e2e-aws-ovn 314e71bcf2fe84f3fe2bce0de59f7c7e3993442c link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-agent-compact-ipv6-minimaliso 314e71bcf2fe84f3fe2bce0de59f7c7e3993442c link false /test e2e-agent-compact-ipv6-minimaliso
ci/prow/e2e-agent-5control-ipv4 314e71bcf2fe84f3fe2bce0de59f7c7e3993442c link false /test e2e-agent-5control-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rwsu commented 4 days ago

/test e2e-agent-compact-ipv4 /test e2e-agent-compact-ipv4-add-nodes

pawanpinjarkar commented 3 hours ago

/test e2e-agent-compact-ipv4-appliance-diskimage

openshift-merge-robot commented 3 hours ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.