openshift / installer

Install an OpenShift 4.x cluster
https://try.openshift.com
Apache License 2.0
1.44k stars 1.39k forks source link

OCPBUGS-44834: aws: include permissions for edge compute #9230

Open r4f4 opened 3 days ago

r4f4 commented 3 days ago

When the installer has to create edge machinepools, extra permissions are needed regarding Carrier Gateways.

openshift-ci-robot commented 3 days ago

@r4f4: This pull request references Jira Issue OCPBUGS-44834, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9230): >When the installer has to create edge machinepools, extra permissions are needed regarding Carrier Gateways. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from r4f4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[pkg/asset/installconfig/aws/OWNERS](https://github.com/openshift/installer/blob/master/pkg/asset/installconfig/aws/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
r4f4 commented 3 days ago

The shared-vpc-edge-zones failure is being fixed by https://github.com/openshift/installer/pull/9234

r4f4 commented 3 days ago

/jira refresh

r4f4 commented 3 days ago

/label platform/aws

openshift-ci-robot commented 3 days ago

@r4f4: This pull request references Jira Issue OCPBUGS-44834, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yunjiang@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/installer/pull/9230#issuecomment-2494930323): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
r4f4 commented 2 days ago

edge-zones: cluster installed but failed the e2e-aws-ovn-edge-zones-nodes-readiness test

/test e2e-aws-ovn-edge-zones

openshift-ci[bot] commented 2 days ago

@r4f4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-edge-zones 6a79a32779ef79b027118a2921c91c63030a22db link false /test e2e-aws-ovn-edge-zones
ci/prow/okd-scos-e2e-aws-ovn 6a79a32779ef79b027118a2921c91c63030a22db link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 6a79a32779ef79b027118a2921c91c63030a22db link false /test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/artifacts-images 6a79a32779ef79b027118a2921c91c63030a22db link true /test artifacts-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).