OCPBUGS-44922: Power VS: SetDefaultPrivateServiceEndpoints mistakenly called for External deploys

[miyamotoh]

In #9165, the default set of endpoint overrides necessary for Internal deploy was set for External as well for CCM. This PR properly conditionalizes the behavior.

[mjturek]

/test e2e-powervs-capi-ovn

[mjturek]

/retitle OCPBUGS-44922: Power VS: SetDefaultPrivateServiceEndpoints mistakenly called for External deploys

[openshift-ci-robot]

@miyamotoh: This pull request references Jira Issue OCPBUGS-44922, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @juliemathew

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/installer/pull/9231): >In #9165, the default set of endpoint overrides necessary for `Internal` deploy was set for `External` as well for CCM. This PR properly conditionalizes the behavior. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[mjturek]

/label acknowledge-critical-fixes-only

[mjturek]

/lgtm

[mjturek]

/assign r4f4

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/installer/blob/master/OWNERS)~~ [r4f4] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@miyamotoh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-powervs-capi-ovn	81f09dec69ee53370ba93dff2d6179ba9e5ae21c	link	false	/test e2e-powervs-capi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@miyamotoh: Jira Issue OCPBUGS-44922: All pull requests linked via external trackers have merged:

• openshift/installer#9231

Jira Issue OCPBUGS-44922 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/installer/pull/9231): >In #9165, the default set of endpoint overrides necessary for `Internal` deploy was set for `External` as well for CCM. This PR properly conditionalizes the behavior. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Finstaller). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra This PR has been included in build ose-installer-altinfra-container-v4.18.0-202411230636.p0.g80d1310.assembly.stream.el9. All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers This PR has been included in build ose-installer-terraform-providers-container-v4.18.0-202411230636.p0.g80d1310.assembly.stream.el9. All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer This PR has been included in build ose-baremetal-installer-container-v4.18.0-202411230636.p0.g80d1310.assembly.stream.el9. All builds following this will include this PR.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts This PR has been included in build ose-installer-artifacts-container-v4.18.0-202411230636.p0.g80d1310.assembly.stream.el9. All builds following this will include this PR.