search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

need to manage konflux dependencies with renovate #168

Closed cpmeadors closed 1 month ago

cpmeadors commented 1 month ago

Konflux uses renovate to maintainer dependencies. https://konflux.pages.redhat.com/docs/users/mintmaker/user.html#introduction This needs to be enable with renovate.json that will override the default configurations. I use a working configuration from another operator: https://github.com/openshift/trustee-operator/blob/main/renovate.json

Dependabot has been disabled so that we only have one dependency updating tool.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [cpmeadors] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harche commented 1 month ago

/lgtm

kannon92 commented 1 month ago

This is concerning. https://konflux.pages.redhat.com/docs/users/mintmaker/user.html#list-of-currently-supported-managers

It looks like golang is not yet supported for konflux renovate.

harche commented 1 month ago

/hold

cpmeadors commented 1 month ago

This is concerning. https://konflux.pages.redhat.com/docs/users/mintmaker/user.html#list-of-currently-supported-managers

It looks like golang is not yet supported for konflux renovate.

The trustee operator I reference is go and it works fine there. I also don't think we have a choice. If we don't do this, then all the references to konflux dependencies aren't maintained and the pipeline will break.

cpmeadors commented 1 month ago

Should we remove dependabot?

I am not clear on how the two would interact I just know that konflux needs this.

cpmeadors commented 1 month ago

This is concerning. https://konflux.pages.redhat.com/docs/users/mintmaker/user.html#list-of-currently-supported-managers It looks like golang is not yet supported for konflux renovate.

The trustee operator I reference is go and it works fine there. I also don't think we have a choice. If we don't do this, then all the references to konflux dependencies aren't maintained and the pipeline will break.

The upstream page https://docs.renovatebot.com/modules/manager/ seems to disagree with the konflux docs. Golang looks supported there.

cpmeadors commented 1 month ago

Should we remove dependabot?

I am not clear on how the two would interact I just know that konflux needs this. Based on a search in the konflux support slack channel, I see many other projects using dependabot as well as renovate. No one is saying there is a conflict.

cpmeadors commented 1 month ago

/retest

rphillips commented 1 month ago

probably should remove the dependabot config in the same pr.

openshift-ci[bot] commented 1 month ago

@cpmeadors: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
harche commented 1 month ago

/hold cancel

rphillips commented 1 month ago

/lgtm

rphillips commented 1 month ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group daemonset-installed-by-controller"

openshift-ci[bot] commented 1 month ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/168#issuecomment-2414896318): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group daemonset-installed-by-controller" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 1 month ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group daemonset-installed-by-controller"

openshift-ci[bot] commented 1 month ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/168#issuecomment-2414903159): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group daemonset-installed-by-controller" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cpmeadors commented 1 month ago

/hold