search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

simplify patch node code daemonset #171

Closed mamy-CS closed 1 month ago

mamy-CS commented 1 month ago

This pr simplifies the code responsible for patching the node with accelerator-memory-quota in the daemonset

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mamy-CS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [mamy-CS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
asm582 commented 1 month ago

/lgtm

rphillips commented 1 month ago

/hold I think there needs to be one update

rphillips commented 1 month ago

Thanks! /hold cancel /lgtm /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset"

openshift-ci[bot] commented 1 month ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/171#issuecomment-2414934424): >Thanks! >/hold cancel >/lgtm >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 1 month ago

/override

openshift-ci[bot] commented 1 month ago

@rphillips: /override requires failed status contexts to operate on, but none was given

In response to [this](https://github.com/openshift/instaslice-operator/pull/171#issuecomment-2414939866): >/override Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 1 month ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset"

openshift-ci[bot] commented 1 month ago

@rphillips: Overrode contexts on behalf of rphillips: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset

In response to [this](https://github.com/openshift/instaslice-operator/pull/171#issuecomment-2415369565): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 1 month ago

/override "Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group simplify-patch-node-status"

openshift-ci[bot] commented 1 month ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/171#issuecomment-2415370276): >/override "Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group simplify-patch-node-status" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 1 month ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group simplify-patch-node-status"

openshift-ci[bot] commented 1 month ago

@rphillips: Overrode contexts on behalf of rphillips: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group simplify-patch-node-status

In response to [this](https://github.com/openshift/instaslice-operator/pull/171#issuecomment-2415370775): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group simplify-patch-node-status" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@mamy-CS: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).