search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

Fix daemonset failure, e2e and unit tests #175

Closed sairameshv closed 1 month ago

sairameshv commented 1 month ago
  1. Fix daemonset container not coming up
  2. Fix e2e, unit test failures
  3. Minor refactors

/cc @asm582 @mamy-CS @rphillips @harche

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mamy-CS, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [mamy-CS,sairameshv] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mamy-CS commented 1 month ago

/override /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group fix-e2e"

openshift-ci[bot] commented 1 month ago

@mamy-CS: /override requires failed status contexts to operate on, but none was given

In response to [this](https://github.com/openshift/instaslice-operator/pull/175#issuecomment-2416937979): >/override >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group fix-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mamy-CS commented 1 month ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group fix-e2e"

openshift-ci[bot] commented 1 month ago

@mamy-CS: Overrode contexts on behalf of mamy-CS: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group fix-e2e

In response to [this](https://github.com/openshift/instaslice-operator/pull/175#issuecomment-2416939931): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-controller" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group fix-e2e" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).