search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

Support running e2e tests on an OCP cluster #177

Closed sairameshv closed 3 weeks ago

sairameshv commented 1 month ago

This change would help in running the defined e2e tests on the OCP cluster without modifying the existing behavior. Thus, a prow job can be added to run these e2e tests on OCP

The dependency here is the images that we rely on, while running the e2e tests on an OCP cluster. These are pulled from @asm582 's quay.io repository today and hence need to be updated periodically to reflect on the correct e2e test results

/cc @asm582 @harche @rphillips @mamy-CS

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [sairameshv] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sairameshv commented 1 month ago

/hold Need to resolve the merge conflicts, address review comments and thoroughly test on OCP clusters

openshift-ci[bot] commented 3 weeks ago

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sairameshv commented 3 weeks ago

This PR supports running e2e tests both on Kind and the OCP cluster But @rphillips got a point that the cluster creation, installation of crds and the operator should be taken out of the e2e test suite. Hence, putting a hold on this PR in favor of Ryan's PR /hold

I would close it once the above PR is merged.

sairameshv commented 3 weeks ago

/close

openshift-merge-robot commented 3 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

@sairameshv: Closed this PR.

In response to [this](https://github.com/openshift/instaslice-operator/pull/177#issuecomment-2455213556): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.