search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

Allow loading local images into Kind for easier development #18

Open empovit opened 3 months ago

empovit commented 3 months ago

There is a way to load local images into a Kind cluster without pushing them into a registry. This can offer a faster turnover for development, and eliminate the need in a remote registry for those who want to experiment. If we stay with Kind for development/demo, we might consider adding the local image option to the scripts.

kannon92 commented 3 months ago

We did this on the Kueue e2e tests if anyone is curious. I can't say I got it working with Podman instead of docker but it seems to work pretty well.

empovit commented 3 months ago

It works with Podman, needs a bit of a workaround though. See this PR.

asm582 commented 2 weeks ago

@empovit do we know what is pending?

empovit commented 2 weeks ago

@asm582 if this has been implemented on Kind with Docker, the issue can be closed. As we discussed already, we can't use Podman because the NVIDIA container toolkit for Podman works with CDI, which isn't good for InstaSlice.

empovit commented 2 weeks ago

Ok, I see it implemented in emulator mode https://github.com/openshift/instaslice-operator/blob/99405c97edb2362c07fe16a0bc4fbcc871258b51/hack/deploy-instaslice-emulated-on-kind.sh#L21, but not in the demo https://github.com/openshift/instaslice-operator/blob/99405c97edb2362c07fe16a0bc4fbcc871258b51/deploy/setup.sh. I also think that setup.sh should move to were the rest of deployment files are.