Clean up daemonset deploy logic and update unit tests

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs

Apache License 2.0

15 stars 12 forks source link

Clean up daemonset deploy logic and update unit tests #180

Closed mamy-CS closed 1 month ago

mamy-CS commented 1 month ago

Continue with rest of reconciling logic after at least one daemonset pod is ready
Dynamic daemonset image name set in controller config (This way no change in documentation is required)
Update unit tests and e2e tests

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mamy-CS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [mamy-CS] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

harche commented 1 month ago

/cc @sairameshv for the review.

harche commented 1 month ago

/lgtm

harche commented 1 month ago

/hold https://github.com/openshift/instaslice-operator/pull/180#discussion_r1806618332

harche commented 1 month ago

/hold cancel /lgtm

openshift-ci[bot] commented 1 month ago

@mamy-CS: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).