search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

implementation to remove prepared #184

Closed asm582 closed 1 month ago

asm582 commented 1 month ago

This PR removes the prepared section from the InstaSlice CR. We can now populate MIGs and co-relate them with allocations in the InstaSlice CR. Changes are made to the CRD, controller and daemonset. The obvious effect of this is increased system performance and determinism. make lint, make test, make test-e2e and daemonset shell scripts all pass locally.

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [asm582] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kannon92 commented 1 month ago

Please have descriptive titles and at least some section on what this PR is.

At a glance, it isn't clear to the reviewer what you want this to achieve.

harche commented 1 month ago

Please have descriptive titles and at least some section on what this PR is.

still in draft.

asm582 commented 1 month ago

Thanks @kannon92 this is WIP for now hence the draft PR, a few more changes are coming in, once done I prefer to update it all at once.

openshift-ci[bot] commented 1 month ago

@asm582: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
harche commented 1 month ago

/lgtm