search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

Upgrade to Kubernetes 1.31.1 #191

Closed kannon92 closed 1 month ago

kannon92 commented 1 month ago

Upgrade Instaslice to Kubernetes 1.31.

Fixes #187

Fixes #

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [kannon92] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harche commented 1 month ago

@kannon92 were you able to run e2e?

kannon92 commented 1 month ago

Nope. I was a bit confused on how to run emulator mode e2e now.

kannon92 commented 1 month ago

/hold

asm582 commented 1 month ago

Nope. I was a bit confused on how to run emulator mode e2e now.

make test-e2e

For the manual testing run:

make deploy-emulated

kannon92 commented 1 month ago

That would pull from the image in your repo. Plus I think those e2e tests assume a GPU.

asm582 commented 1 month ago

That would pull from the image in your repo. Plus I think those e2e tests assume a GPU.

you can add any repo to this command:

IMG=quay.io/amalvank/instaslicev2-controller-dev IMG_DMST=quay.io/amalvank/instaslicev2-daemonset-dev make <your-command>
kannon92 commented 1 month ago

So looking at those e2e tests I see that they are also a GPU container. I don't know if those would run in emulator mode.

I can get a kind cluster working where I load the image and try a few smoke tests.

kannon92 commented 1 month ago

/hold cancel

@harche @asm582

I don't really like pushing images to a registry but I was able to build the images, load them into kind and run a few samples for the emulator pod.

Pods were scheduled.

@sairameshv is working on making the e2e tests easier to work with emulator mode and customer clusters so I think this is sufficient on my end.

asm582 commented 1 month ago

@kannon92 Thanks for this PR, I have run daemonset shell scripts on the GPU node and they all pass. I would recommend we resolve merge conflicts if any post #194 is merged and again run tests before merging this PR.

kannon92 commented 1 month ago

@asm582 looks like there wasn't any conflicts.

You want to give this your lgtm.

asm582 commented 1 month ago

/lgtm

kannon92 commented 1 month ago

/override

openshift-ci[bot] commented 1 month ago

@kannon92: /override requires failed status contexts to operate on, but none was given

In response to [this](https://github.com/openshift/instaslice-operator/pull/191#issuecomment-2433518230): >/override Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kannon92 commented 1 month ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group upgrade-k8s-1.30"

openshift-ci[bot] commented 1 month ago

@kannon92: Overrode contexts on behalf of kannon92: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group upgrade-k8s-1.30

In response to [this](https://github.com/openshift/instaslice-operator/pull/191#issuecomment-2433519884): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group upgrade-k8s-1.30" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@kannon92: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).