search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
9 stars 12 forks source link

Refactor to create and destroy kind cluster in e2e tests #192

Open sairameshv opened 2 hours ago

sairameshv commented 2 hours ago 
          I think we could refactor this PR to create the kind cluster in the Makefile? Correct?

_Originally posted by @rphillips in https://github.com/openshift/instaslice-operator/pull/177#discussion_r1806676712_

sairameshv commented 2 hours ago

Separating the targets to create and destroy kind clusters leaves the test suite to just fetch the existing kubeconfig and proceed running the e2e tests. This helps the test suite to be agnostic to the cluster type and so the extra checks can be removed from the code and restrict the changes just to the Makefile