search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

Refactor to create and destroy kind cluster in e2e tests #192

Closed sairameshv closed 2 weeks ago

sairameshv commented 1 month ago 
          I think we could refactor this PR to create the kind cluster in the Makefile? Correct?

_Originally posted by @rphillips in https://github.com/openshift/instaslice-operator/pull/177#discussion_r1806676712_

sairameshv commented 1 month ago

Separating the targets to create and destroy kind clusters leaves the test suite to just fetch the existing kubeconfig and proceed running the e2e tests. This helps the test suite to be agnostic to the cluster type and so the extra checks can be removed from the code and restrict the changes just to the Makefile

sairameshv commented 2 weeks ago

/close Closing this issue as the change is part of the following PRs https://github.com/openshift/instaslice-operator/pull/203 https://github.com/openshift/instaslice-operator/pull/232

openshift-ci[bot] commented 2 weeks ago

@sairameshv: Closing this issue.

In response to [this](https://github.com/openshift/instaslice-operator/issues/192#issuecomment-2464323943): >/close >Closing this issue as the change is part of the following PRs >https://github.com/openshift/instaslice-operator/pull/203 >https://github.com/openshift/instaslice-operator/pull/232 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.