search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

miscellaneous fixes for demo #194

Closed asm582 closed 4 weeks ago

asm582 commented 1 month ago

This PR has changes that enable the system to be demo-ready.

make-test, make test-e2e, make lint and daemonset shell scripts all pass locally.

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [asm582,kannon92] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 weeks ago

@asm582: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kannon92 commented 4 weeks ago

/lgtm

kannon92 commented 4 weeks ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group konflux/references/main"

kannon92 commented 4 weeks ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group logging"

openshift-ci[bot] commented 4 weeks ago

@kannon92: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/194#issuecomment-2433464069): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group konflux/references/main" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 4 weeks ago

@kannon92: Overrode contexts on behalf of kannon92: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group logging

In response to [this](https://github.com/openshift/instaslice-operator/pull/194#issuecomment-2433464889): > >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group logging" > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kannon92 commented 4 weeks ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" /override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset"

openshift-ci[bot] commented 4 weeks ago

@kannon92: Overrode contexts on behalf of kannon92: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle, Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset

In response to [this](https://github.com/openshift/instaslice-operator/pull/194#issuecomment-2433466474): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.