search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

Add downstream specific dockerfiles and bundle dir #200

Closed cpmeadors closed 3 weeks ago

cpmeadors commented 1 month ago

This PR adds the files necessary for downstream builds without limiting the ability to make upstream builds and releases. I had to add one additional make target to make this easier to manage. I also added some of the necessary downstream changes necessary for productization.

operator runs as nonroot now Added kustomizationfiles so that daemonset can run root

How to test:

oc new-project instaslice-system

operator-sdk run bundle quay.io/redhat-user-workloads/dynamicacceleratorsl-tenant/instaslice-operator-bundle@sha256:4f442009b6b986d2a9b94969be5dd3e93e7821c307fe811b888ca3037f2a7b2f --namespace instaslice-system (bundle use sha that matches op-pr- tag)

update CSV to point operator image and daemonset image to konflux build images, i.e.: quay.io/redhat-user-workloads/dynamicacceleratorsl-tenant/dynamicacceleratorslicer/instaslice-operator@sha256:381462c114dd3b07b42413d99db351a37e702654d73341e51dd30935e32f16f4 and quay.io/redhat-user-workloads/dynamicacceleratorsl-tenant/instaslice-daemonset@sha256:2f0e7ca4bb16763c49dc6544e412f3cfb4df2762a01c40229080acc5d86d0d55

Also update EMULATOR_MODE: true in CSV

oc apply -f config/rbac/instaslice-operator-scc.yaml (FIXME)

oc label node/ nvidia.com/mig.capable=true

oc apply -f test/e2e/resources/instaslice-fake-capacity.yaml (edit name to match node hostname)

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [cpmeadors] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cpmeadors commented 1 month ago

/hold

cpmeadors commented 3 weeks ago

/unhold

cpmeadors commented 3 weeks ago

/ok-to-test

cpmeadors commented 3 weeks ago

/test "Red Hat Konflux / instaslice-operator-on-pull-request"

openshift-ci[bot] commented 3 weeks ago

@cpmeadors: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/instaslice-operator/pull/200#issuecomment-2449769717): >/test "Red Hat Konflux / instaslice-operator-on-pull-request" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cpmeadors commented 3 weeks ago

/retest

cpmeadors commented 3 weeks ago

/retest

cpmeadors commented 3 weeks ago

/retest

cpmeadors commented 3 weeks ago

/retest

rphillips commented 3 weeks ago

/test lint

openshift-ci[bot] commented 3 weeks ago

@cpmeadors: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 3 weeks ago

/lgtm