search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

initial refactor of kind e2e tests #203

Closed rphillips closed 3 weeks ago

rphillips commented 3 weeks ago

The following e2e suite succeeds:

make test-e2e-kind-emulated
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
asm582 commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

@rphillips: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 3 weeks ago

/override Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group panic-fix /override Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset /override Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle /override Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator

openshift-ci[bot] commented 3 weeks ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/203#issuecomment-2447932529): >/override Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / pr group panic-fix >/override Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset >/override Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle >/override Red Hat Konflux / Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 3 weeks ago

/override dynamicacceleratorslicer-enterprise-contract

openshift-ci[bot] commented 3 weeks ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/203#issuecomment-2447934454): >/override dynamicacceleratorslicer-enterprise-contract > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 3 weeks ago

/override Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset

openshift-ci[bot] commented 3 weeks ago

@rphillips: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/instaslice-operator/pull/203#issuecomment-2447950162): >/override Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 3 weeks ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset"

openshift-ci[bot] commented 3 weeks ago

@rphillips: Overrode contexts on behalf of rphillips: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset

In response to [this](https://github.com/openshift/instaslice-operator/pull/203#issuecomment-2447951142): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-daemonset" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 3 weeks ago

/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle"

openshift-ci[bot] commented 3 weeks ago

@rphillips: Overrode contexts on behalf of rphillips: Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle

In response to [this](https://github.com/openshift/instaslice-operator/pull/203#issuecomment-2447952328): >/override "Red Hat Konflux / dynamicacceleratorslicer-enterprise-contract / instaslice-operator-bundle" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rphillips commented 3 weeks ago

/override "Red Hat Konflux / instaslice-operator-on-pull-request"

openshift-ci[bot] commented 3 weeks ago

@rphillips: Overrode contexts on behalf of rphillips: Red Hat Konflux / instaslice-operator-on-pull-request

In response to [this](https://github.com/openshift/instaslice-operator/pull/203#issuecomment-2447954430): >/override "Red Hat Konflux / instaslice-operator-on-pull-request" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.