Closed asm582 closed 2 weeks ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: asm582
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@asm582: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
On OpenShift SNO install slices were not deleted in some instances. The root cause of this issue is unknown as it is not reproducible on the KinD cluster; one theory is that multiple NVML init calls could cause non-determinism in slice discovery, and an issue is opened for such a use case in #225. This PR has improved logging when a slice is not found and retries when a slice is not found, but the config map for workload still exists in the system.
make test
,make lint
,make test-e2e
and daemonset shell script all pass locally.