search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

use pinned images #220

Closed cpmeadors closed 2 weeks ago

cpmeadors commented 2 weeks ago

Image urls need to be pinned with shas. This will allow konflux to update the shas as new images are built.

I also added an annotation to the ocp bundle to define the subscriptions.

cpmeadors commented 2 weeks ago

/retest

cpmeadors commented 2 weeks ago

/test all

cpmeadors commented 2 weeks ago

/test "Red Hat Konflux / instaslice-daemonset-on-pull-request"

openshift-ci[bot] commented 2 weeks ago

@cpmeadors: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/instaslice-operator/pull/220#issuecomment-2455292624): >/test "Red Hat Konflux / instaslice-daemonset-on-pull-request" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cpmeadors commented 2 weeks ago

/retest

cpmeadors commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

@cpmeadors: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/instaslice-operator/pull/220#issuecomment-2455649532): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [cpmeadors,sairameshv] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [cpmeadors,sairameshv] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 weeks ago

@cpmeadors: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).