search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
15 stars 12 forks source link

use new deamonset-ocp in konflux #249

Closed cpmeadors closed 2 days ago

cpmeadors commented 3 days ago

Need to changed the dockerfile that konflux was pointing to for building the daemonset now that there is an OCP specific file. This is a follow up to PR 244.

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/instaslice-operator/blob/main/OWNERS)~~ [cpmeadors] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cpmeadors commented 3 days ago

/retest

cpmeadors commented 3 days ago

/ok-to-test /lgtm

openshift-ci[bot] commented 3 days ago

@cpmeadors: you cannot LGTM your own PR.

In response to [this](https://github.com/openshift/instaslice-operator/pull/249#issuecomment-2484042404): >/ok-to-test >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cpmeadors commented 2 days ago

/retest

harche commented 2 days ago

/lgtm

openshift-ci[bot] commented 2 days ago

@cpmeadors: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).