search

openshift / instaslice-operator

InstaSlice Operator facilitates slicing of accelerators using stable APIs
Apache License 2.0
17 stars 12 forks source link

Add unit test for daemonset #61

Closed asm582 closed 1 day ago

asm582 commented 2 months ago

create unit tests for daemonset that will run on GPU-enabled cluster, and run locally to verify the output

kannon92 commented 2 months ago

That would not be unit test then. Unit tests should never require specific hardware requirements.

asm582 commented 2 months ago

I agree, I think until we can "truly" mock a GPU this could be an approach.

asm582 commented 2 months ago

@sairameshv @mamy-CS PR #67 shows a possible path, based on it I think more tests could be added.

harche commented 2 months ago

/assign @sairameshv

kannon92 commented 6 days ago

Can we close?

sairameshv commented 3 days ago

I'm working on it @kannon92