Forcing error in Jenkins builds on exec error/fail

openshift / jenkins-plugin

Apache License 2.0

81 stars 50 forks source link

Forcing error in Jenkins builds on exec error/fail #105

Closed jupierce closed 7 years ago

jupierce commented 7 years ago

QE requested to fail job if there are errors in the underlying exec API: https://bugzilla.redhat.com/show_bug.cgi?id=1390491

jupierce commented 7 years ago

ptal @gabemontero

jupierce commented 7 years ago

The new behavior should be as follows:

Timeouts/failures/errors should cause traditional builds to fail.
DSL jobs will only fail because of exec timeouts. This should allow DSL scripts to handle errors via scripting.

bparees commented 7 years ago

lgtm but will definitely defer to @gabemontero

bparees commented 7 years ago

I'm amenable to merging this evening and letting @jupierce handle the comments in a subsequent PR tomorrow if we are anxious to let QE validate the change. Just let me know - thanks.

i think we're fine to wait.

jupierce commented 7 years ago

Additions to README.MD and new string constants in last push.

Types of errors: (1) Pod not present (2) Specified container not present in pod (3) Command not found (e.g. "echo1" vs "echo") (4) Timeout

Freestyle job killed by: 1, 2, 3, 4 DSL job killed by: 1, 5

gabemontero commented 7 years ago

IGTM - even though @jupierce 's extended test fixes got in before this started, I need to make the tweaks to the PR test job for everything to take hold. So not waiting on this PR test job.